Revision: 28571
http://sourceforge.net/p/bibdesk/svn/28571
Author: hofman
Date: 2024-01-07 17:06:40 +0000 (Sun, 07 Jan 2024)
Log Message:
-----------
should not retain controller during modal window session
Modified Paths:
--------------
trunk/bibdesk/BDSKWebViewModalDialogController.h
trunk/bibdesk/BDSKWebViewModalDialogController.m
Modified: trunk/bibdesk/BDSKWebViewModalDialogController.h
===================================================================
--- trunk/bibdesk/BDSKWebViewModalDialogController.h 2024-01-07 16:58:08 UTC
(rev 28570)
+++ trunk/bibdesk/BDSKWebViewModalDialogController.h 2024-01-07 17:06:40 UTC
(rev 28571)
@@ -44,7 +44,6 @@
@interface BDSKWebViewModalDialogController : NSWindowController
<BDSKWebViewDelegate, NSWindowDelegate> {
BDSKWebView *webView;
BDSKStatusBar *statusBar;
- id strongSelf;
}
@property (nonatomic, readonly) BDSKWebView *webView;
@end
Modified: trunk/bibdesk/BDSKWebViewModalDialogController.m
===================================================================
--- trunk/bibdesk/BDSKWebViewModalDialogController.m 2024-01-07 16:58:08 UTC
(rev 28570)
+++ trunk/bibdesk/BDSKWebViewModalDialogController.m 2024-01-07 17:06:40 UTC
(rev 28571)
@@ -70,7 +70,6 @@
- (void)windowWillClose:(NSNotification *)notification {
[NSApp stopModal];
- BDSKDESTROY(strongSelf);
}
#pragma mark BDSKWebViewDelegate protocol
@@ -88,7 +87,6 @@
}
- (void)webViewRunModal:(WebView *)sender {
- strongSelf = [self retain];
// we can't use [NSApp runModalForWindow], because otherwise the webview
does not download, and also it won't receive any close message from javascript
// http://www.dejal.com/blog/2007/01/cocoa-topics-case-modal-webview
NSModalSession session = [NSApp beginModalSessionForWindow:[self window]];
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Bibdesk-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bibdesk-commit
