Revision: 28579
http://sourceforge.net/p/bibdesk/svn/28579
Author: hofman
Date: 2024-01-08 23:27:08 +0000 (Mon, 08 Jan 2024)
Log Message:
-----------
always assign self after releasing it
Modified Paths:
--------------
trunk/bibdesk/BDSKNotesWindowController.m
trunk/bibdesk/BDSKVersionNumber.m
trunk/bibdesk/BDSKWebParser.m
trunk/bibdesk/BibDocument.m
trunk/bibdesk/NSMenu_BDSKExtensions.m
trunk/bibdesk/NSString_BDSKExtensions.m
Modified: trunk/bibdesk/BDSKNotesWindowController.m
===================================================================
--- trunk/bibdesk/BDSKNotesWindowController.m 2024-01-08 17:20:21 UTC (rev
28578)
+++ trunk/bibdesk/BDSKNotesWindowController.m 2024-01-08 23:27:08 UTC (rev
28579)
@@ -61,6 +61,7 @@
if (self) {
if (aURL == nil) {
[self release];
+ self = nil;
return nil;
}
Modified: trunk/bibdesk/BDSKVersionNumber.m
===================================================================
--- trunk/bibdesk/BDSKVersionNumber.m 2024-01-08 17:20:21 UTC (rev 28578)
+++ trunk/bibdesk/BDSKVersionNumber.m 2024-01-08 23:27:08 UTC (rev 28579)
@@ -84,6 +84,7 @@
// Input might be from a NSBundle info dictionary that could be
misconfigured, so check at runtime too
if ([versionString isKindOfClass:[NSString class]] == NO) {
[self release];
+ self = nil;
return nil;
}
@@ -163,6 +164,7 @@
if (componentCount == 0) {
// Failed to parse anything and we don't allow empty version
strings. For now, we'll not assert on this, since people might want to use
this to detect if a string begins with a valid version number.
[self release];
+ self = nil;
return nil;
}
}
Modified: trunk/bibdesk/BDSKWebParser.m
===================================================================
--- trunk/bibdesk/BDSKWebParser.m 2024-01-08 17:20:21 UTC (rev 28578)
+++ trunk/bibdesk/BDSKWebParser.m 2024-01-08 23:27:08 UTC (rev 28579)
@@ -159,6 +159,7 @@
- (id)init {
[self release];
+ self = nil;
return nil;
}
@@ -165,6 +166,7 @@
- (id)initWithDocument:(DOMDocument *)aDomDocument fromURL:(NSURL *)aURL {
if (aDomDocument == nil || aURL == nil) {
[self release];
+ self = nil;
return nil;
}
self = [super init];
Modified: trunk/bibdesk/BibDocument.m
===================================================================
--- trunk/bibdesk/BibDocument.m 2024-01-08 17:20:21 UTC (rev 28578)
+++ trunk/bibdesk/BibDocument.m 2024-01-08 23:27:08 UTC (rev 28579)
@@ -264,6 +264,7 @@
// I consider this an AppKit bug
- (id)initWithCoder:(NSCoder *)coder {
[self release];
+ self = nil;
return nil;
}
Modified: trunk/bibdesk/NSMenu_BDSKExtensions.m
===================================================================
--- trunk/bibdesk/NSMenu_BDSKExtensions.m 2024-01-08 17:20:21 UTC (rev
28578)
+++ trunk/bibdesk/NSMenu_BDSKExtensions.m 2024-01-08 23:27:08 UTC (rev
28579)
@@ -156,6 +156,7 @@
- (id)initWithCoder:(NSCoder *)decoder {
[self release];
+ self = nil;
return [sharedOpenWithController retain];
}
Modified: trunk/bibdesk/NSString_BDSKExtensions.m
===================================================================
--- trunk/bibdesk/NSString_BDSKExtensions.m 2024-01-08 17:20:21 UTC (rev
28578)
+++ trunk/bibdesk/NSString_BDSKExtensions.m 2024-01-08 23:27:08 UTC (rev
28579)
@@ -267,7 +267,8 @@
[data release];
[[self init] release];
- return string;
+ self = self;
+ return self;
}
#pragma mark TeX cleaning
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Bibdesk-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bibdesk-commit
