Revision: 28669
          http://sourceforge.net/p/bibdesk/svn/28669
Author:   hofman
Date:     2024-01-24 16:50:58 +0000 (Wed, 24 Jan 2024)
Log Message:
-----------
don't add drop highlight view when nothing is dropped

Modified Paths:
--------------
    trunk/bibdesk_vendorsrc/amaxwell/FileView/FVFileView.m

Modified: trunk/bibdesk_vendorsrc/amaxwell/FileView/FVFileView.m
===================================================================
--- trunk/bibdesk_vendorsrc/amaxwell/FileView/FVFileView.m      2024-01-24 
16:15:44 UTC (rev 28668)
+++ trunk/bibdesk_vendorsrc/amaxwell/FileView/FVFileView.m      2024-01-24 
16:50:58 UTC (rev 28669)
@@ -2844,7 +2844,7 @@
         dragOp = NSDragOperationLink;
     }
     
-    // we could allow the delegate to change the _dropIndex and 
_fvFlags.dropOperation as NSTableView does, but we don't use that at present
+    // we allow the delegate to change the _dropIndex and 
_fvFlags.dropOperation as NSTableView does
     if ([[self delegate] 
respondsToSelector:@selector(fileView:validateDrop:proposedIndex:proposedDropOperation:proposedDragOperation:)])
         dragOp = [[self delegate] fileView:self validateDrop:sender 
proposedIndex:_dropIndex proposedDropOperation:_fvFlags.dropOperation 
proposedDragOperation:dragOp];
     
@@ -2854,7 +2854,7 @@
         _fvFlags.dropOperation = FVDropBefore;
     }
     
-    if (_dropHighlightView == nil) {
+    if (dragOp != NSDragOperationNone && _dropHighlightView == nil) {
         _dropHighlightView = [[FVDropHighlightView alloc] initWithFrame:[self 
bounds]];
         [(FVDropHighlightView *)_dropHighlightView setDelegate:self];
         [self addSubview:_dropHighlightView];

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.



_______________________________________________
Bibdesk-commit mailing list
Bibdesk-commit@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bibdesk-commit

Reply via email to