Revision: 29040
http://sourceforge.net/p/bibdesk/svn/29040
Author: hofman
Date: 2025-02-20 18:13:38 +0000 (Thu, 20 Feb 2025)
Log Message:
-----------
include isRetrieving check in should~RetrievePublications property
Modified Paths:
--------------
trunk/bibdesk/BDSKExternalGroup.m
trunk/bibdesk/BDSKSharedGroup.m
trunk/bibdesk/BDSKURLGroup.m
Modified: trunk/bibdesk/BDSKExternalGroup.m
===================================================================
--- trunk/bibdesk/BDSKExternalGroup.m 2025-02-20 10:42:23 UTC (rev 29039)
+++ trunk/bibdesk/BDSKExternalGroup.m 2025-02-20 18:13:38 UTC (rev 29040)
@@ -169,7 +169,7 @@
[self notifyUpdateForPublications:oldPublications];
}
-- (BOOL)shouldRetrievePublications { return publications == nil; }
+- (BOOL)shouldRetrievePublications { return publications == nil && [self
isRetrieving] == NO; }
- (void)retrievePublications {}
@@ -176,7 +176,7 @@
- (void)stopRetrieving {}
- (void)wantsPublicationsImmediately:(BOOL)immediate {
- if ([self isRetrieving] == NO && [self shouldRetrievePublications])
+ if ([self shouldRetrievePublications])
[self retrievePublications];
}
Modified: trunk/bibdesk/BDSKSharedGroup.m
===================================================================
--- trunk/bibdesk/BDSKSharedGroup.m 2025-02-20 10:42:23 UTC (rev 29039)
+++ trunk/bibdesk/BDSKSharedGroup.m 2025-02-20 18:13:38 UTC (rev 29040)
@@ -141,7 +141,7 @@
}
- (BOOL)shouldRetrievePublications {
- return [self needsUpdate] || ([super shouldRetrievePublications] &&
[client failedDownload] == NO);
+ return [self isRetrieving] == NO && ([self needsUpdate] || (publications
== nil && [client failedDownload] == NO));
}
- (void)retrievePublications {
Modified: trunk/bibdesk/BDSKURLGroup.m
===================================================================
--- trunk/bibdesk/BDSKURLGroup.m 2025-02-20 10:42:23 UTC (rev 29039)
+++ trunk/bibdesk/BDSKURLGroup.m 2025-02-20 18:13:38 UTC (rev 29040)
@@ -217,12 +217,12 @@
}
- (void)wantsPublicationsImmediately:(BOOL)immediate {
- if ([self isRetrieving] == NO && [self shouldRetrievePublications]) {
+ if ([self shouldRetrievePublications]) {
if (immediate || [[self URL] isFileURL] == NO)
[self retrievePublications];
else
dispatch_async(dispatch_get_main_queue(), ^{
- if ([self isRetrieving] == NO && [self
shouldRetrievePublications])
+ if ([self shouldRetrievePublications])
[self retrievePublications];
});
}
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Bibdesk-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bibdesk-commit
