Revision: 29277
http://sourceforge.net/p/bibdesk/svn/29277
Author: hofman
Date: 2025-07-14 09:18:01 +0000 (Mon, 14 Jul 2025)
Log Message:
-----------
No need to fully implement NSEditor in filter controller
Modified Paths:
--------------
trunk/bibdesk/BDSKFilterController.h
trunk/bibdesk/BDSKFilterController.m
Modified: trunk/bibdesk/BDSKFilterController.h
===================================================================
--- trunk/bibdesk/BDSKFilterController.h 2025-07-14 09:15:17 UTC (rev
29276)
+++ trunk/bibdesk/BDSKFilterController.h 2025-07-14 09:18:01 UTC (rev
29277)
@@ -72,9 +72,7 @@
@property (nonatomic, readonly) NSArray *conditions;
@property (nonatomic, readonly) BOOL hasMultipleConditions;
-- (void)discardEditing;
- (BOOL)commitEditing;
-- (void)commitEditingWithDelegate:(nullable id)delegate
didCommitSelector:(nullable SEL)didCommitSelector contextInfo:(nullable void
*)contextInfo;
@property (nonatomic, readonly) NSUndoManager *undoManager;
Modified: trunk/bibdesk/BDSKFilterController.m
===================================================================
--- trunk/bibdesk/BDSKFilterController.m 2025-07-14 09:15:17 UTC (rev
29276)
+++ trunk/bibdesk/BDSKFilterController.m 2025-07-14 09:18:01 UTC (rev
29277)
@@ -274,10 +274,6 @@
#pragma mark NSEditor
-- (void)discardEditing {
- [conditionControllers
makeObjectsPerformSelector:@selector(discardEditing)];
-}
-
- (BOOL)commitEditing {
for (BDSKConditionController *controller in conditionControllers) {
if (NO == [controller commitEditing])
@@ -286,18 +282,6 @@
return YES;
}
-- (void)commitEditingWithDelegate:(id)delegate
didCommitSelector:(SEL)didCommitSelector contextInfo:(void *)contextInfo {
- BOOL didCommit = [self commitEditing];
- if (delegate && didCommitSelector) {
- // - (void)editor:(id)editor didCommit:(BOOL)didCommit
contextInfo:(void *)contextInfo
- dispatch_async(dispatch_get_main_queue(), ^{
- void (*didCommitImp)(id, SEL, id, BOOL, void *) = (void (*)(id,
SEL, id, BOOL, void *))[delegate methodForSelector:didCommitSelector];
- if (didCommitImp)
- didCommitImp(delegate, didCommitSelector, self, didCommit,
contextInfo);
- });
- }
-}
-
#pragma mark Undo support
- (NSUndoManager *)undoManager{
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Bibdesk-commit mailing list
Bibdesk-commit@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bibdesk-commit
