Revision: 29280
http://sourceforge.net/p/bibdesk/svn/29280
Author: hofman
Date: 2025-07-15 09:33:52 +0000 (Tue, 15 Jul 2025)
Log Message:
-----------
rename method and parameter
Modified Paths:
--------------
trunk/bibdesk/BDSKCharacterConversion.m
trunk/bibdesk/BDSKSearchGroupSheetController.m
trunk/bibdesk/NSWindowController_BDSKExtensions.h
trunk/bibdesk/NSWindowController_BDSKExtensions.m
Modified: trunk/bibdesk/BDSKCharacterConversion.m
===================================================================
--- trunk/bibdesk/BDSKCharacterConversion.m 2025-07-15 09:28:35 UTC (rev
29279)
+++ trunk/bibdesk/BDSKCharacterConversion.m 2025-07-15 09:33:52 UTC (rev
29280)
@@ -167,12 +167,12 @@
#pragma mark Actions
-- (BOOL)shouldDismissSheetWithResult:(NSModalResponse)result {
+- (BOOL)shouldDismissSheetWithReturnCode:(NSModalResponse)returnCode {
// commit edit before saving
- if ([super shouldDismissSheetWithResult:result] == NO)
+ if ([super shouldDismissSheetWithReturnCode:returnCode] == NO)
return NO;
- if (result == NSModalResponseOK) {
+ if (returnCode == NSModalResponseOK) {
if (!validRoman || !validTex) {
NSAlert *alert = [[NSAlert alloc] init];
[alert setMessageText:NSLocalizedString(@"Invalid Conversion",
@"Message in alert dialog when entering invalid TeX conversion")];
Modified: trunk/bibdesk/BDSKSearchGroupSheetController.m
===================================================================
--- trunk/bibdesk/BDSKSearchGroupSheetController.m 2025-07-15 09:28:35 UTC
(rev 29279)
+++ trunk/bibdesk/BDSKSearchGroupSheetController.m 2025-07-15 09:33:52 UTC
(rev 29280)
@@ -153,10 +153,10 @@
#pragma mark Actions
-- (BOOL)shouldDismissSheetWithResult:(NSModalResponse)result {
- if ([super shouldDismissSheetWithResult:result] == NO)
+- (BOOL)shouldDismissSheetWithReturnCode:(NSModalResponse)returnCode {
+ if ([super shouldDismissSheetWithReturnCode:returnCode] == NO)
return NO;
- if (result == NSModalResponseOK && [self isEditable])
+ if (returnCode == NSModalResponseOK && [self isEditable])
[serverInfo savePasswordInKeychain];
return YES;
}
Modified: trunk/bibdesk/NSWindowController_BDSKExtensions.h
===================================================================
--- trunk/bibdesk/NSWindowController_BDSKExtensions.h 2025-07-15 09:28:35 UTC
(rev 29279)
+++ trunk/bibdesk/NSWindowController_BDSKExtensions.h 2025-07-15 09:33:52 UTC
(rev 29280)
@@ -53,7 +53,7 @@
- (IBAction)dismiss:(nullable id)sender;
-- (BOOL)shouldDismissSheetWithResult:(NSModalResponse)result;
+- (BOOL)shouldDismissSheetWithReturnCode:(NSModalResponse)returnCode;
- (void)didDismissSheet;
@end
Modified: trunk/bibdesk/NSWindowController_BDSKExtensions.m
===================================================================
--- trunk/bibdesk/NSWindowController_BDSKExtensions.m 2025-07-15 09:28:35 UTC
(rev 29279)
+++ trunk/bibdesk/NSWindowController_BDSKExtensions.m 2025-07-15 09:33:52 UTC
(rev 29280)
@@ -101,8 +101,8 @@
}];
}
-- (BOOL)shouldDismissSheetWithResult:(NSModalResponse)result {
- if (result == NSModalResponseCancel) {
+- (BOOL)shouldDismissSheetWithReturnCode:(NSModalResponse)returnCode {
+ if (returnCode == NSModalResponseCancel) {
if ([self respondsToSelector:@selector(discardEditing)])
[self discardEditing];
} else if ([self respondsToSelector:@selector(commitEditing)]) {
@@ -114,7 +114,7 @@
- (void)didDismissSheet {}
- (IBAction)dismiss:(id)sender {
- if ([self shouldDismissSheetWithResult:[sender tag]] == NO) {
+ if ([self shouldDismissSheetWithReturnCode:[sender tag]] == NO) {
NSBeep();
return;
}
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Bibdesk-commit mailing list
Bibdesk-commit@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bibdesk-commit
