Revision: 29283
http://sourceforge.net/p/bibdesk/svn/29283
Author: hofman
Date: 2025-07-17 17:21:21 +0000 (Thu, 17 Jul 2025)
Log Message:
-----------
return early from commit and discard editing methods when we are not editing,
avoids validating cite key value the user already accepted
Modified Paths:
--------------
trunk/bibdesk/BDSKEditor.m
Modified: trunk/bibdesk/BDSKEditor.m
===================================================================
--- trunk/bibdesk/BDSKEditor.m 2025-07-17 17:14:31 UTC (rev 29282)
+++ trunk/bibdesk/BDSKEditor.m 2025-07-17 17:21:21 UTC (rev 29283)
@@ -363,6 +363,9 @@
- (void)discardEditing
{
+ if (editorFlags.isEditing == NO)
+ return;
+
id firstResponder = [[self window] firstResponder];
// check textviews first
if ([firstResponder isKindOfClass:[NSText class]]) {
@@ -412,6 +415,9 @@
- (BOOL)commitEditing
{
+ if (editorFlags.isEditing == NO)
+ return YES;
+
NSResponder *firstResponder = [[self window] firstResponder];
/*
@@ -461,6 +467,9 @@
- (BOOL)commitEditingAndReturnError:(NSError **)error
{
+ if (editorFlags.isEditing == NO)
+ return YES;
+
NSResponder *firstResponder = [[self window] firstResponder];
/*
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Bibdesk-commit mailing list
Bibdesk-commit@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bibdesk-commit
