[Bibdesk-commit] SF.net SVN: bibdesk:[29424] trunk/bibdesk

[hofman--- via Bibdesk-commit]

Revision: 29424
          http://sourceforge.net/p/bibdesk/svn/29424
Author:   hofman
Date:     2025-08-11 21:14:26 +0000 (Mon, 11 Aug 2025)
Log Message:
-----------
implement stringValueOfAttribute: in element class, returning nil in all other 
node classes

Modified Paths:
--------------
    trunk/bibdesk/DOMNode_BDSKExtensions.m
    trunk/bibdesk/NSXMLNode_BDSKExtensions.m

Modified: trunk/bibdesk/DOMNode_BDSKExtensions.m
===================================================================
--- trunk/bibdesk/DOMNode_BDSKExtensions.m      2025-08-09 15:26:30 UTC (rev 
29423)
+++ trunk/bibdesk/DOMNode_BDSKExtensions.m      2025-08-11 21:14:26 UTC (rev 
29424)
@@ -130,8 +130,17 @@
 }
 
 - (NSString *)stringValueOfAttribute:(NSString *)attrName {
-    if ([self nodeType] != DOM_ELEMENT_NODE)
-        return nil;
+    return nil;
+}
+
+@end
+
+@interface DOMElement (BDSKExtensions)
+@end
+
+@implementation DOMElement (BDSKExtensions)
+
+- (NSString *)stringValueOfAttribute:(NSString *)attrName {
     return[(DOMElement *)self getAttribute:attrName];
 }
 

Modified: trunk/bibdesk/NSXMLNode_BDSKExtensions.m
===================================================================
--- trunk/bibdesk/NSXMLNode_BDSKExtensions.m    2025-08-09 15:26:30 UTC (rev 
29423)
+++ trunk/bibdesk/NSXMLNode_BDSKExtensions.m    2025-08-11 21:14:26 UTC (rev 
29424)
@@ -42,9 +42,19 @@
 @implementation NSXMLNode (BDSKExtensions)
 
 - (NSString *)stringValueOfAttribute:(NSString *)attrName{
-    if ([self kind] != NSXMLElementKind)
-        return nil;
-    return [[(NSXMLElement *)self attributeForName:attrName] stringValue];
+    return nil;
 }
 
 @end
+
+@interface NSXMLElement (BDSKExtensions)
+@end
+
+@implementation NSXMLElement (BDSKExtensions)
+
+- (NSString *)stringValueOfAttribute:(NSString *)attrName{
+    return [[self attributeForName:attrName] stringValue];
+}
+
+@end
+

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.



_______________________________________________
Bibdesk-commit mailing list
Bibdesk-commit@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bibdesk-commit