Revision: 29514
http://sourceforge.net/p/bibdesk/svn/29514
Author: hofman
Date: 2025-08-31 14:23:36 +0000 (Sun, 31 Aug 2025)
Log Message:
-----------
don't display duplicate web history items, e.g. from a downloads page form
submit
Modified Paths:
--------------
trunk/bibdesk/BDSKWebGroupViewController.m
Modified: trunk/bibdesk/BDSKWebGroupViewController.m
===================================================================
--- trunk/bibdesk/BDSKWebGroupViewController.m 2025-08-31 13:59:47 UTC (rev
29513)
+++ trunk/bibdesk/BDSKWebGroupViewController.m 2025-08-31 14:23:36 UTC (rev
29514)
@@ -196,14 +196,18 @@
else
return;
[menu removeAllItems];
+ NSString *urlString = [[[self webView] URL] absoluteString];
for (WebHistoryItem *item in items) {
+ if ([[item URLString] isEqualToString:urlString])
+ continue;
+ urlString = [item URLString];
NSString *title = [item title];
if ([NSString isEmptyString:title]) {
- NSURL *url = [NSURL URLWithString:[item URLString]];
+ NSURL *url = [NSURL URLWithString:urlString];
title = [url isFileURL] ? [url lastPathComponent] : [[url
absoluteString] stringByRemovingPercentEncoding];
}
NSMenuItem *menuItem = [menu addItemWithTitle:title
action:@selector(goBackForwardInHistory:) keyEquivalent:@""];
- [menuItem setImageAndSize:[[BDSKWebIconDatabase sharedDatabase]
iconForURLString:[item URLString]] ?: [NSImage imageNamed:@"Bookmark"]];
+ [menuItem setImageAndSize:[[BDSKWebIconDatabase sharedDatabase]
iconForURLString:urlString] ?: [NSImage imageNamed:@"Bookmark"]];
[menuItem setTarget:self];
[menuItem setRepresentedObject:item];
}
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Bibdesk-commit mailing list
Bibdesk-commit@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bibdesk-commit
