Revision: 29725
http://sourceforge.net/p/bibdesk/svn/29725
Author: hofman
Date: 2025-10-14 09:29:04 +0000 (Tue, 14 Oct 2025)
Log Message:
-----------
declare only NSString as paramater of initWithName: for group
Modified Paths:
--------------
trunk/bibdesk/BDSKCategoryGroup.h
trunk/bibdesk/BDSKCategoryGroup.m
trunk/bibdesk/BDSKExternalGroup.m
trunk/bibdesk/BDSKGroup.h
trunk/bibdesk/BDSKGroup.m
trunk/bibdesk/BDSKParentGroup.h
trunk/bibdesk/BDSKParentGroup.m
trunk/bibdesk/BDSKScriptGroup.h
trunk/bibdesk/BDSKSharedGroup.h
trunk/bibdesk/BDSKSharedGroup.m
trunk/bibdesk/BDSKSmartGroup.m
trunk/bibdesk/BDSKStaticGroup.m
trunk/bibdesk/BDSKURLGroup.m
Modified: trunk/bibdesk/BDSKCategoryGroup.h
===================================================================
--- trunk/bibdesk/BDSKCategoryGroup.h 2025-10-14 09:23:41 UTC (rev 29724)
+++ trunk/bibdesk/BDSKCategoryGroup.h 2025-10-14 09:29:04 UTC (rev 29725)
@@ -54,7 +54,7 @@
*/
- (instancetype)initWithName:(id)aName key:(NSString *)aKey
NS_DESIGNATED_INITIALIZER;
- (instancetype)initWithCoder:(NSCoder *)coder NS_DESIGNATED_INITIALIZER;
-- (instancetype)initWithName:(id)aName NS_UNAVAILABLE;
+- (instancetype)initWithName:(NSString *)aName NS_UNAVAILABLE;
@property (nonatomic, readonly) NSString *key;
Modified: trunk/bibdesk/BDSKCategoryGroup.m
===================================================================
--- trunk/bibdesk/BDSKCategoryGroup.m 2025-10-14 09:23:41 UTC (rev 29724)
+++ trunk/bibdesk/BDSKCategoryGroup.m 2025-10-14 09:29:04 UTC (rev 29725)
@@ -54,8 +54,9 @@
// designated initializer
- (instancetype)initWithName:(id)aName key:(NSString *)aKey {
- self = [super initWithName:aName];
+ self = [super initWithName:[aName description]];
if (self) {
+ name = aName;
key = [aKey copy];
}
return self;
@@ -62,7 +63,7 @@
}
// super's designated initializer
-- (instancetype)initWithName:(id)aName {
+- (instancetype)initWithName:(NSString *)aName {
self = nil;
return self;
}
Modified: trunk/bibdesk/BDSKExternalGroup.m
===================================================================
--- trunk/bibdesk/BDSKExternalGroup.m 2025-10-14 09:23:41 UTC (rev 29724)
+++ trunk/bibdesk/BDSKExternalGroup.m 2025-10-14 09:29:04 UTC (rev 29725)
@@ -52,7 +52,7 @@
@dynamic shouldRetrievePublications;
// designated initializer
-- (instancetype)initWithName:(id)aName {
+- (instancetype)initWithName:(NSString *)aName {
NSAssert(aName != nil, @"External group requires a name");
self = [super initWithName:aName];
Modified: trunk/bibdesk/BDSKGroup.h
===================================================================
--- trunk/bibdesk/BDSKGroup.h 2025-10-14 09:23:41 UTC (rev 29724)
+++ trunk/bibdesk/BDSKGroup.h 2025-10-14 09:29:04 UTC (rev 29725)
@@ -81,7 +81,7 @@
@discussion This is the designated initializer.
@param aName The name for the group.
*/
-- (instancetype)initWithName:(id)aName NS_DESIGNATED_INITIALIZER;
+- (instancetype)initWithName:(NSString *)aName NS_DESIGNATED_INITIALIZER;
- (instancetype)initWithDictionary:(NSDictionary *)groupDict;
Modified: trunk/bibdesk/BDSKGroup.m
===================================================================
--- trunk/bibdesk/BDSKGroup.m 2025-10-14 09:23:41 UTC (rev 29724)
+++ trunk/bibdesk/BDSKGroup.m 2025-10-14 09:29:04 UTC (rev 29725)
@@ -59,7 +59,7 @@
}
// designated initializer
-- (instancetype)initWithName:(id)aName {
+- (instancetype)initWithName:(NSString *)aName {
self = [super init];
if (self) {
name = [aName copy];
Modified: trunk/bibdesk/BDSKParentGroup.h
===================================================================
--- trunk/bibdesk/BDSKParentGroup.h 2025-10-14 09:23:41 UTC (rev 29724)
+++ trunk/bibdesk/BDSKParentGroup.h 2025-10-14 09:29:04 UTC (rev 29725)
@@ -104,7 +104,7 @@
- (instancetype)initWithKey:(NSString *)aKey NS_DESIGNATED_INITIALIZER;
- (instancetype)initWithCoder:(NSCoder *)coderr NS_DESIGNATED_INITIALIZER;
-- (instancetype)initWithName:(id)aName NS_UNAVAILABLE;
+- (instancetype)initWithName:(NSString *)aName NS_UNAVAILABLE;
@property (nonatomic, strong) NSArray *categoryGroups;
Modified: trunk/bibdesk/BDSKParentGroup.m
===================================================================
--- trunk/bibdesk/BDSKParentGroup.m 2025-10-14 09:23:41 UTC (rev 29724)
+++ trunk/bibdesk/BDSKParentGroup.m 2025-10-14 09:29:04 UTC (rev 29725)
@@ -200,7 +200,7 @@
return [self initWithName:NSLocalizedString(@"Groups", @"source list group
row title")];
}
-- (instancetype)initWithName:(id)aName {
+- (instancetype)initWithName:(NSString *)aName {
self = [super initWithName:aName];
if (self) {
BDSKGroup *libraryGroup = [[BDSKLibraryGroup alloc] init];
@@ -235,7 +235,7 @@
return [self initWithName:NSLocalizedString(@"External", @"source list
group row title")];
}
-- (instancetype)initWithName:(id)aName {
+- (instancetype)initWithName:(NSString *)aName {
self = [super initWithName:aName];
if (self) {
webGroupCount = 0;
Modified: trunk/bibdesk/BDSKScriptGroup.h
===================================================================
--- trunk/bibdesk/BDSKScriptGroup.h 2025-10-14 09:23:41 UTC (rev 29724)
+++ trunk/bibdesk/BDSKScriptGroup.h 2025-10-14 09:29:04 UTC (rev 29725)
@@ -63,7 +63,7 @@
- (instancetype)initWithScriptPath:(NSString *)path scriptArguments:(nullable
NSString *)arguments;
- (instancetype)initWithName:(nullable NSString *)aName scriptPath:(NSString
*)path scriptArguments:(nullable NSString *)arguments
scriptType:(BDSKScriptType)type NS_DESIGNATED_INITIALIZER;
- (instancetype)initWithCoder:(NSCoder *)coder NS_DESIGNATED_INITIALIZER;
-- (instancetype)initWithName:(id)aName NS_UNAVAILABLE;
+- (instancetype)initWithName:(NSString *)aName NS_UNAVAILABLE;
@property (nonatomic, strong) NSString *scriptPath;
@property (nonatomic, nullable, strong) NSString *scriptArguments;
Modified: trunk/bibdesk/BDSKSharedGroup.h
===================================================================
--- trunk/bibdesk/BDSKSharedGroup.h 2025-10-14 09:23:41 UTC (rev 29724)
+++ trunk/bibdesk/BDSKSharedGroup.h 2025-10-14 09:29:04 UTC (rev 29725)
@@ -54,7 +54,7 @@
- (instancetype)initWithClient:(BDSKSharingClient *)aClient
NS_DESIGNATED_INITIALIZER;
- (instancetype)initWithCoder:(NSCoder *)decoder NS_UNAVAILABLE;
-- (instancetype)initWithName:(id)aName NS_UNAVAILABLE;
+- (instancetype)initWithName:(NSString *)aName NS_UNAVAILABLE;
@property (nonatomic, readonly) BDSKSharingClient *client;
@property (nonatomic, readonly) BOOL needsUpdate;
Modified: trunk/bibdesk/BDSKSharedGroup.m
===================================================================
--- trunk/bibdesk/BDSKSharedGroup.m 2025-10-14 09:23:41 UTC (rev 29724)
+++ trunk/bibdesk/BDSKSharedGroup.m 2025-10-14 09:29:04 UTC (rev 29725)
@@ -98,7 +98,7 @@
#pragma mark Init and dealloc
// old designated initializer
-- (instancetype)initWithName:(id)aName;
+- (instancetype)initWithName:(NSString *)aName;
{
self = nil;
return self;
Modified: trunk/bibdesk/BDSKSmartGroup.m
===================================================================
--- trunk/bibdesk/BDSKSmartGroup.m 2025-10-14 09:23:41 UTC (rev 29724)
+++ trunk/bibdesk/BDSKSmartGroup.m 2025-10-14 09:29:04 UTC (rev 29725)
@@ -51,7 +51,7 @@
@synthesize filter;
// super's designated initializer
-- (instancetype)initWithName:(id)aName {
+- (instancetype)initWithName:(NSString *)aName {
BDSKFilter *aFilter = [[BDSKFilter alloc] init];
self = [self initWithName:aName filter:aFilter];
return self;
Modified: trunk/bibdesk/BDSKStaticGroup.m
===================================================================
--- trunk/bibdesk/BDSKStaticGroup.m 2025-10-14 09:23:41 UTC (rev 29724)
+++ trunk/bibdesk/BDSKStaticGroup.m 2025-10-14 09:29:04 UTC (rev 29725)
@@ -61,7 +61,7 @@
}
// super's designated initializer
-- (instancetype)initWithName:(id)aName {
+- (instancetype)initWithName:(NSString *)aName {
self = [self initWithName:aName publications:nil];
return self;
}
Modified: trunk/bibdesk/BDSKURLGroup.m
===================================================================
--- trunk/bibdesk/BDSKURLGroup.m 2025-10-14 09:23:41 UTC (rev 29724)
+++ trunk/bibdesk/BDSKURLGroup.m 2025-10-14 09:29:04 UTC (rev 29725)
@@ -58,7 +58,7 @@
@synthesize URL;
// old designated initializer
-- (instancetype)initWithName:(id)aName;
+- (instancetype)initWithName:(NSString *)aName;
{
self = nil;
return self;
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Bibdesk-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bibdesk-commit
