Revision: 29742
http://sourceforge.net/p/bibdesk/svn/29742
Author: hofman
Date: 2025-10-20 09:31:43 +0000 (Mon, 20 Oct 2025)
Log Message:
-----------
mark designated initializers in FileView framework
Modified Paths:
--------------
trunk/bibdesk_vendorsrc/amaxwell/FileView/FVAccessibilityIconElement.h
trunk/bibdesk_vendorsrc/amaxwell/FileView/FVBaseIcon.m
trunk/bibdesk_vendorsrc/amaxwell/FileView/FVCGColorSpaceDescription.h
trunk/bibdesk_vendorsrc/amaxwell/FileView/FVCGImageDescription.h
trunk/bibdesk_vendorsrc/amaxwell/FileView/FVDownload.h
trunk/bibdesk_vendorsrc/amaxwell/FileView/FVIconOperation.h
trunk/bibdesk_vendorsrc/amaxwell/FileView/FVImageBuffer.h
trunk/bibdesk_vendorsrc/amaxwell/FileView/FVInvocationOperation.h
trunk/bibdesk_vendorsrc/amaxwell/FileView/FVOperation.h
trunk/bibdesk_vendorsrc/amaxwell/FileView/FVPriorityQueue.h
trunk/bibdesk_vendorsrc/amaxwell/FileView/_FVSplitSet.h
Modified: trunk/bibdesk_vendorsrc/amaxwell/FileView/FVAccessibilityIconElement.h
===================================================================
--- trunk/bibdesk_vendorsrc/amaxwell/FileView/FVAccessibilityIconElement.h
2025-10-20 08:48:58 UTC (rev 29741)
+++ trunk/bibdesk_vendorsrc/amaxwell/FileView/FVAccessibilityIconElement.h
2025-10-20 09:31:43 UTC (rev 29742)
@@ -43,7 +43,8 @@
NSUInteger _index;
__weak id _parent;
}
-- (id)initWithIndex:(NSUInteger)anIndex parent:(id)aParent;
+- (id)initWithIndex:(NSUInteger)anIndex parent:(id)aParent
NS_DESIGNATED_INITIALIZER;
+- (id)init NS_UNAVAILABLE;
@property (nonatomic, readonly) NSUInteger index;
@end
Modified: trunk/bibdesk_vendorsrc/amaxwell/FileView/FVBaseIcon.m
===================================================================
--- trunk/bibdesk_vendorsrc/amaxwell/FileView/FVBaseIcon.m 2025-10-20
08:48:58 UTC (rev 29741)
+++ trunk/bibdesk_vendorsrc/amaxwell/FileView/FVBaseIcon.m 2025-10-20
09:31:43 UTC (rev 29742)
@@ -48,7 +48,7 @@
- (id)initWithURL:(NSURL *)aURL drawsLinkBadge:(BOOL)drawsLinkBadge;
{
- self = [self init];
+ self = [super init];
if (self) {
_drawsLinkBadge = drawsLinkBadge;
_fileURL = aURL;
Modified: trunk/bibdesk_vendorsrc/amaxwell/FileView/FVCGColorSpaceDescription.h
===================================================================
--- trunk/bibdesk_vendorsrc/amaxwell/FileView/FVCGColorSpaceDescription.h
2025-10-20 08:48:58 UTC (rev 29741)
+++ trunk/bibdesk_vendorsrc/amaxwell/FileView/FVCGColorSpaceDescription.h
2025-10-20 09:31:43 UTC (rev 29742)
@@ -49,7 +49,9 @@
unsigned char *_colorTable; // length is _colorTableLength *
_baseColorSpaceComponents
}
-- (id)initWithColorSpace:(CGColorSpaceRef)colorSpace;
+- (id)initWithColorSpace:(CGColorSpaceRef)colorSpace NS_DESIGNATED_INITIALIZER;
+- (id)initWithCoder:(NSCoder *)decoder NS_DESIGNATED_INITIALIZER;
+- (id)init NS_UNAVAILABLE;
- (CGColorSpaceRef)newColorSpace;
@end
Modified: trunk/bibdesk_vendorsrc/amaxwell/FileView/FVCGImageDescription.h
===================================================================
--- trunk/bibdesk_vendorsrc/amaxwell/FileView/FVCGImageDescription.h
2025-10-20 08:48:58 UTC (rev 29741)
+++ trunk/bibdesk_vendorsrc/amaxwell/FileView/FVCGImageDescription.h
2025-10-20 09:31:43 UTC (rev 29742)
@@ -61,7 +61,9 @@
CGImageRef _image;
}
-- (id)initWithImage:(CGImageRef)image;
+- (id)initWithImage:(CGImageRef)image NS_DESIGNATED_INITIALIZER;
+- (id)initWithCoder:(NSCoder *)decoder NS_DESIGNATED_INITIALIZER;
+- (id)init NS_UNAVAILABLE;
- (CGImageRef)newImage;
@end
Modified: trunk/bibdesk_vendorsrc/amaxwell/FileView/FVDownload.h
===================================================================
--- trunk/bibdesk_vendorsrc/amaxwell/FileView/FVDownload.h 2025-10-20
08:48:58 UTC (rev 29741)
+++ trunk/bibdesk_vendorsrc/amaxwell/FileView/FVDownload.h 2025-10-20
09:31:43 UTC (rev 29742)
@@ -52,7 +52,8 @@
__weak id<FVDownloadDelegate> _delegate;
NSURLDownload *_download;
}
-- (id)initWithDownloadURL:(NSURL *)aURL indexInView:(NSUInteger)indexInView
replace:(BOOL)replace;
+- (id)initWithDownloadURL:(NSURL *)aURL indexInView:(NSUInteger)indexInView
replace:(BOOL)replace NS_DESIGNATED_INITIALIZER;
+- (id)init NS_UNAVAILABLE;
@property (nonatomic, weak) id<FVDownloadDelegate> delegate;
Modified: trunk/bibdesk_vendorsrc/amaxwell/FileView/FVIconOperation.h
===================================================================
--- trunk/bibdesk_vendorsrc/amaxwell/FileView/FVIconOperation.h 2025-10-20
08:48:58 UTC (rev 29741)
+++ trunk/bibdesk_vendorsrc/amaxwell/FileView/FVIconOperation.h 2025-10-20
09:31:43 UTC (rev 29742)
@@ -49,7 +49,8 @@
}
// designated initializer; uses @selector(iconUpdated:) as callback (sent to
view with icon as argument)
-- (id)initWithIcon:(FVIcon *)icon view:(FVFileView *)view;
+- (id)initWithIcon:(FVIcon *)icon view:(FVFileView *)view
NS_DESIGNATED_INITIALIZER;
+- (id)init NS_UNAVAILABLE;
@end
Modified: trunk/bibdesk_vendorsrc/amaxwell/FileView/FVImageBuffer.h
===================================================================
--- trunk/bibdesk_vendorsrc/amaxwell/FileView/FVImageBuffer.h 2025-10-20
08:48:58 UTC (rev 29741)
+++ trunk/bibdesk_vendorsrc/amaxwell/FileView/FVImageBuffer.h 2025-10-20
09:31:43 UTC (rev 29742)
@@ -67,7 +67,7 @@
Callers must pass an explicit size.
@return An initialized buffer instance. */
-- (id)init;
+- (id)init NS_UNAVAILABLE;
/** @internal @brief Designated initializer.
Modified: trunk/bibdesk_vendorsrc/amaxwell/FileView/FVInvocationOperation.h
===================================================================
--- trunk/bibdesk_vendorsrc/amaxwell/FileView/FVInvocationOperation.h
2025-10-20 08:48:58 UTC (rev 29741)
+++ trunk/bibdesk_vendorsrc/amaxwell/FileView/FVInvocationOperation.h
2025-10-20 09:31:43 UTC (rev 29742)
@@ -52,7 +52,10 @@
}
/** Designated initializer. */
-- (id)initWithInvocation:(NSInvocation *)inv;
+- (id)initWithInvocation:(NSInvocation *)inv NS_DESIGNATED_INITIALIZER;
+
+- (id)init NS_UNAVAILABLE;
+
/** Convenience initializer.
This method still creates an NSInvocation, so there's no performance win.
Modified: trunk/bibdesk_vendorsrc/amaxwell/FileView/FVOperation.h
===================================================================
--- trunk/bibdesk_vendorsrc/amaxwell/FileView/FVOperation.h 2025-10-20
08:48:58 UTC (rev 29741)
+++ trunk/bibdesk_vendorsrc/amaxwell/FileView/FVOperation.h 2025-10-20
09:31:43 UTC (rev 29742)
@@ -73,7 +73,7 @@
}
/** Designated initializer. */
-- (id)init;
+- (id)init NS_DESIGNATED_INITIALIZER;
/** Hash value.
Modified: trunk/bibdesk_vendorsrc/amaxwell/FileView/FVPriorityQueue.h
===================================================================
--- trunk/bibdesk_vendorsrc/amaxwell/FileView/FVPriorityQueue.h 2025-10-20
08:48:58 UTC (rev 29741)
+++ trunk/bibdesk_vendorsrc/amaxwell/FileView/FVPriorityQueue.h 2025-10-20
09:31:43 UTC (rev 29742)
@@ -69,7 +69,7 @@
}
/** Designated intializer. */
-- (id)init;
+- (id)initWithCapacity:(NSUInteger)capacity NS_DESIGNATED_INITIALIZER;
/** Single-object access.
@return The highest priority item; if several items have highest priority,
returns any of those items. */
Modified: trunk/bibdesk_vendorsrc/amaxwell/FileView/_FVSplitSet.h
===================================================================
--- trunk/bibdesk_vendorsrc/amaxwell/FileView/_FVSplitSet.h 2025-10-20
08:48:58 UTC (rev 29741)
+++ trunk/bibdesk_vendorsrc/amaxwell/FileView/_FVSplitSet.h 2025-10-20
09:31:43 UTC (rev 29742)
@@ -46,7 +46,7 @@
NSUInteger _split;
}
-- (id)initWithSplit:(NSUInteger)split;
+- (id)initWithSplit:(NSUInteger)split NS_DESIGNATED_INITIALIZER;
@property (nonatomic, readonly) NSUInteger split;
- (void)addObject:(id)obj;
- (void)removeObject:(id)obj;
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Bibdesk-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bibdesk-commit
