Revision: 29744
http://sourceforge.net/p/bibdesk/svn/29744
Author: hofman
Date: 2025-10-20 16:14:23 +0000 (Mon, 20 Oct 2025)
Log Message:
-----------
use class extensions instead of Private category
Modified Paths:
--------------
trunk/bibdesk/BDSKAsyncObject.m
trunk/bibdesk/BDSKBibDeskProtocol.m
trunk/bibdesk/BDSKBookmarkController.m
trunk/bibdesk/BDSKButtonBar.m
trunk/bibdesk/BDSKConditionController.m
trunk/bibdesk/BDSKConverter.m
trunk/bibdesk/BDSKDocumentController.m
trunk/bibdesk/BDSKEditorTextView.m
trunk/bibdesk/BDSKFieldEditor.m
trunk/bibdesk/BDSKFileMatcher.m
trunk/bibdesk/BDSKFilterController.m
trunk/bibdesk/BDSKFontWell.m
trunk/bibdesk/BDSKFormatParser.m
trunk/bibdesk/BDSKGroupBubbleView.m
trunk/bibdesk/BDSKHCiteParser.m
trunk/bibdesk/BDSKItemPasteboardHelper.m
trunk/bibdesk/BDSKMacroResolver.m
trunk/bibdesk/BDSKMainTableView.m
trunk/bibdesk/BDSKMergeController.m
trunk/bibdesk/BDSKNotesSearchIndex.m
trunk/bibdesk/BDSKNotesWindowController.m
trunk/bibdesk/BDSKOrphanedFilesFinder.m
trunk/bibdesk/BDSKPubMedParser.m
trunk/bibdesk/BDSKPublicationsArray.m
trunk/bibdesk/BDSKRISParser.m
trunk/bibdesk/BDSKScriptGroup.m
trunk/bibdesk/BDSKScrollableTextFieldCell.m
trunk/bibdesk/BDSKSearchBookmarkController.m
trunk/bibdesk/BDSKSpringerParser.m
trunk/bibdesk/BDSKStringEncodingManager.m
trunk/bibdesk/BDSKTask.m
trunk/bibdesk/BDSKTemplate.m
trunk/bibdesk/BDSKTemplateDocument.m
trunk/bibdesk/BDSKTypeSelectHelper.m
trunk/bibdesk/BDSKWebGroup.m
trunk/bibdesk/BDSKZoomablePDFView.m
trunk/bibdesk/BDSKZoomableTextView.m
trunk/bibdesk/BibAuthor.m
trunk/bibdesk/BibPref_AutoFile.m
trunk/bibdesk/BibPref_Cite.m
trunk/bibdesk/BibPref_CiteKey.m
trunk/bibdesk/BibPref_Crossref.m
trunk/bibdesk/BibPref_Export.m
trunk/bibdesk/BibPref_Sharing.m
Modified: trunk/bibdesk/BDSKAsyncObject.m
===================================================================
--- trunk/bibdesk/BDSKAsyncObject.m 2025-10-20 14:34:30 UTC (rev 29743)
+++ trunk/bibdesk/BDSKAsyncObject.m 2025-10-20 16:14:23 UTC (rev 29744)
@@ -38,7 +38,7 @@
#import "BDSKAsyncObject.h"
-@interface BDSKAsyncObject (Private)
+@interface BDSKAsyncObject ()
- (void)runLocalThread;
- (void)stopRunning;
@end
Modified: trunk/bibdesk/BDSKBibDeskProtocol.m
===================================================================
--- trunk/bibdesk/BDSKBibDeskProtocol.m 2025-10-20 14:34:30 UTC (rev 29743)
+++ trunk/bibdesk/BDSKBibDeskProtocol.m 2025-10-20 16:14:23 UTC (rev 29744)
@@ -55,7 +55,7 @@
NSString *BDSKBibDeskScheme = @"bibdesk";
-@interface BDSKBibDeskProtocol (Private)
+@interface BDSKBibDeskProtocol ()
- (NSData *)HTMLDataUsingTemplateFile:(NSString *)template
usingObject:(id)object;
@end
Modified: trunk/bibdesk/BDSKBookmarkController.m
===================================================================
--- trunk/bibdesk/BDSKBookmarkController.m 2025-10-20 14:34:30 UTC (rev
29743)
+++ trunk/bibdesk/BDSKBookmarkController.m 2025-10-20 16:14:23 UTC (rev
29744)
@@ -76,7 +76,7 @@
static char BDSKBookmarkPropertiesObservationContext;
-@interface BDSKBookmarkController (BDSKPrivate)
+@interface BDSKBookmarkController ()
- (void)setupToolbar;
- (void)handleApplicationWillTerminateNotification:(NSNotification
*)notification;
- (void)endEditing;
Modified: trunk/bibdesk/BDSKButtonBar.m
===================================================================
--- trunk/bibdesk/BDSKButtonBar.m 2025-10-20 14:34:30 UTC (rev 29743)
+++ trunk/bibdesk/BDSKButtonBar.m 2025-10-20 16:14:23 UTC (rev 29744)
@@ -45,7 +45,7 @@
#define BUTTON_SEPARATION 2.0
-@interface BDSKButtonBar (BDSKPrivate)
+@interface BDSKButtonBar ()
- (void)clickButton:(id)sender;
- (void)tile;
@end
Modified: trunk/bibdesk/BDSKConditionController.m
===================================================================
--- trunk/bibdesk/BDSKConditionController.m 2025-10-20 14:34:30 UTC (rev
29743)
+++ trunk/bibdesk/BDSKConditionController.m 2025-10-20 16:14:23 UTC (rev
29744)
@@ -52,7 +52,7 @@
static char BDSKConditionControllerObservationContext;
-@interface BDSKConditionController (BDSKPrivate)
+@interface BDSKConditionController ()
- (void)startObserving;
- (void)stopObserving;
- (void)layoutValueControls;
Modified: trunk/bibdesk/BDSKConverter.m
===================================================================
--- trunk/bibdesk/BDSKConverter.m 2025-10-20 14:34:30 UTC (rev 29743)
+++ trunk/bibdesk/BDSKConverter.m 2025-10-20 16:14:23 UTC (rev 29744)
@@ -39,7 +39,7 @@
#import "NSFileManager_BDSKExtensions.h"
#import "NSError_BDSKExtensions.h"
-@interface BDSKConverter (Private)
+@interface BDSKConverter ()
- (void)setDetexifyAccents:(NSDictionary *)newAccents;
- (void)setAccentCharacterSet:(NSCharacterSet *)charSet;
- (void)setBaseCharacterSetForTeX:(NSCharacterSet *)charSet;
@@ -374,10 +374,8 @@
return NO;
}
-@end
+#pragma mark Private
-@implementation BDSKConverter (Private)
-
- (void)setDetexifyAccents:(NSDictionary *)newAccents{
if(detexifyAccents != newAccents){
detexifyAccents = [newAccents copy];
Modified: trunk/bibdesk/BDSKDocumentController.m
===================================================================
--- trunk/bibdesk/BDSKDocumentController.m 2025-10-20 14:34:30 UTC (rev
29743)
+++ trunk/bibdesk/BDSKDocumentController.m 2025-10-20 16:14:23 UTC (rev
29744)
@@ -78,7 +78,7 @@
- (IBAction)newWindowForTab:(id)sender;
@end
-@interface BDSKDocumentController (BDSKPrivate)
+@interface BDSKDocumentController ()
- (void)handleWindowDidBecomeMainNotification:(NSNotification *)notification;
@end
Modified: trunk/bibdesk/BDSKEditorTextView.m
===================================================================
--- trunk/bibdesk/BDSKEditorTextView.m 2025-10-20 14:34:30 UTC (rev 29743)
+++ trunk/bibdesk/BDSKEditorTextView.m 2025-10-20 16:14:23 UTC (rev 29744)
@@ -44,7 +44,7 @@
static char BDSKEditorTextViewDefaultsObservationContext;
-@interface BDSKEditorTextView (Private)
+@interface BDSKEditorTextView ()
- (void)updateFontFromPreferences;
Modified: trunk/bibdesk/BDSKFieldEditor.m
===================================================================
--- trunk/bibdesk/BDSKFieldEditor.m 2025-10-20 14:34:30 UTC (rev 29743)
+++ trunk/bibdesk/BDSKFieldEditor.m 2025-10-20 16:14:23 UTC (rev 29744)
@@ -44,7 +44,7 @@
- (NSTextView *)currentTextView;
@end
-@interface BDSKFieldEditor (Private)
+@interface BDSKFieldEditor ()
- (BOOL)delegateHandlesDragOperation:(id <NSDraggingInfo>)sender;
- (void)doAutoCompleteIfPossible;
@@ -260,12 +260,8 @@
isCompleting = NO;
}
-@end
-
#pragma mark -
-@implementation BDSKFieldEditor (Private)
-
#pragma mark Delegated drag methods
- (BOOL)delegateHandlesDragOperation:(id <NSDraggingInfo>)sender {
Modified: trunk/bibdesk/BDSKFileMatcher.m
===================================================================
--- trunk/bibdesk/BDSKFileMatcher.m 2025-10-20 14:34:30 UTC (rev 29743)
+++ trunk/bibdesk/BDSKFileMatcher.m 2025-10-20 16:14:23 UTC (rev 29744)
@@ -76,7 +76,7 @@
@interface BDSKTreeNode (BDSKQuickLook) <QLPreviewItem>
@end
-@interface BDSKFileMatcher (Private)
+@interface BDSKFileMatcher ()
- (NSArray *)copyTreeNodesWithPublications:(NSArray *)pubs;
- (void)searchIndex:(SKIndexRef)searchIndex withPublicationNodes:(NSArray
*)pubNodes;
@@ -378,10 +378,8 @@
return NO;
}
-@end
+#pragma mark Private
-@implementation BDSKFileMatcher (Private)
-
static NSString *searchStringWithPub(BibItem *pub)
{
// may be better ways to do this, but we'll try search for title and then
append the first author's last name (if available) (note that we're not using
phrase search at the moment, since it causes an occasional crash; that would
require enclosing title in double quotes
Modified: trunk/bibdesk/BDSKFilterController.m
===================================================================
--- trunk/bibdesk/BDSKFilterController.m 2025-10-20 14:34:30 UTC (rev
29743)
+++ trunk/bibdesk/BDSKFilterController.m 2025-10-20 16:14:23 UTC (rev
29744)
@@ -47,7 +47,7 @@
#define BDSKTouchBarItemIdentifierButtons
@"edu.ucsd.mmccrack.bibdesk.touchbar-item.buttons"
-@interface BDSKFilterController (BDSKPrivate)
+@interface BDSKFilterController ()
- (void)insertConditionView:(BDSKConditionController *)aConditionController
atIndex:(NSUInteger)idx;
- (void)addConditionViews:(NSArray *)views;
- (void)removeConditionView:(BDSKConditionController *)aConditionController;
Modified: trunk/bibdesk/BDSKFontWell.m
===================================================================
--- trunk/bibdesk/BDSKFontWell.m 2025-10-20 14:34:30 UTC (rev 29743)
+++ trunk/bibdesk/BDSKFontWell.m 2025-10-20 16:14:23 UTC (rev 29744)
@@ -57,7 +57,7 @@
#define TARGET_KEY @"target"
-@interface BDSKFontWell (BDSKPrivate)
+@interface BDSKFontWell ()
- (void)changeActive:(id)sender;
@end
Modified: trunk/bibdesk/BDSKFormatParser.m
===================================================================
--- trunk/bibdesk/BDSKFormatParser.m 2025-10-20 14:34:30 UTC (rev 29743)
+++ trunk/bibdesk/BDSKFormatParser.m 2025-10-20 16:14:23 UTC (rev 29744)
@@ -56,7 +56,7 @@
#import <zlib.h>
-@interface BDSKFormatParser (BDSKPrivate)
+@interface BDSKFormatParser ()
+ (NSString *)parseFormat:(NSString *)format forField:(NSString *)fieldName
linkedFile:(BDSKLinkedFile *)file ofItem:(id <BDSKParseableItem>)pub;
Modified: trunk/bibdesk/BDSKGroupBubbleView.m
===================================================================
--- trunk/bibdesk/BDSKGroupBubbleView.m 2025-10-20 14:34:30 UTC (rev 29743)
+++ trunk/bibdesk/BDSKGroupBubbleView.m 2025-10-20 16:14:23 UTC (rev 29744)
@@ -40,7 +40,7 @@
#import "NSColor_BDSKExtensions.h"
-@interface BDSKGroupBubbleView (BDSKPrivate)
+@interface BDSKGroupBubbleView ()
- (void)updateMaterial:(id)sender;
@end
Modified: trunk/bibdesk/BDSKHCiteParser.m
===================================================================
--- trunk/bibdesk/BDSKHCiteParser.m 2025-10-20 14:34:30 UTC (rev 29743)
+++ trunk/bibdesk/BDSKHCiteParser.m 2025-10-20 16:14:23 UTC (rev 29744)
@@ -44,7 +44,7 @@
#import "DOMNode_BDSKExtensions.h"
-@interface BDSKHCiteParser (Private)
+@interface BDSKHCiteParser ()
- (NSDate *)dateFromNode:(DOMNode *)node;
- (NSString *)fullStringValueIfABBRFromNode:(DOMNode *)node;
- (BOOL)nodeHasContainerParent:(DOMNode *)node;
Modified: trunk/bibdesk/BDSKItemPasteboardHelper.m
===================================================================
--- trunk/bibdesk/BDSKItemPasteboardHelper.m 2025-10-20 14:34:30 UTC (rev
29743)
+++ trunk/bibdesk/BDSKItemPasteboardHelper.m 2025-10-20 16:14:23 UTC (rev
29744)
@@ -51,7 +51,7 @@
#define TEXTASKRESULT_KEY @"texTaskResult"
-@interface BDSKItemPasteboardHelper (Private) <BDSKTeXTaskDelegate>
+@interface BDSKItemPasteboardHelper () <BDSKTeXTaskDelegate>
- (BOOL)pasteboardIsValid:(NSPasteboard *)pboard;
- (void)setPromisedTypes:(NSMutableArray *)types items:(NSArray *)items
dragCopyType:(BDSKDragCopyType)dragCopyType forPasteboard:(NSPasteboard
*)pboard;
@@ -222,11 +222,8 @@
return [self pasteboardIsValid:pboard] ? [[promisedPboardTypes
objectForKey:[pboard name]] objectForKey:ITEMS_KEY] : nil;
}
-@end
+#pragma mark Private
-
-@implementation BDSKItemPasteboardHelper (Private)
-
- (BOOL)pasteboardIsValid:(NSPasteboard *)pboard
{
// see bug #1791132
https://sourceforge.net/tracker/index.php?func=detail&aid=1791132&group_id=61487&atid=497423
Modified: trunk/bibdesk/BDSKMacroResolver.m
===================================================================
--- trunk/bibdesk/BDSKMacroResolver.m 2025-10-20 14:34:30 UTC (rev 29743)
+++ trunk/bibdesk/BDSKMacroResolver.m 2025-10-20 16:14:23 UTC (rev 29744)
@@ -73,7 +73,7 @@
@end
-@interface BDSKMacroResolver (Private)
+@interface BDSKMacroResolver ()
- (void)loadMacroDefinitions;
- (void)synchronize;
- (void)addMacro:(NSString *)macro toArray:(NSMutableArray *)array;
@@ -258,11 +258,8 @@
return [[self macroDefinitions] objectForKey:macro];
}
-@end
+#pragma mark Private
-
-@implementation BDSKMacroResolver (Private)
-
- (void)loadMacroDefinitions{
// Note we treat upper and lowercase values the same,
// because that's how btparse gives the string constants to us.
Modified: trunk/bibdesk/BDSKMainTableView.m
===================================================================
--- trunk/bibdesk/BDSKMainTableView.m 2025-10-20 14:34:30 UTC (rev 29743)
+++ trunk/bibdesk/BDSKMainTableView.m 2025-10-20 16:14:23 UTC (rev 29744)
@@ -53,7 +53,7 @@
#import "NSGeometry_BDSKExtensions.h"
-@interface BDSKMainTableView (Private)
+@interface BDSKMainTableView ()
- (NSImage *)headerImageForField:(NSString *)field;
- (NSString *)headerTitleForField:(NSString *)field;
@@ -359,11 +359,8 @@
[self scrollRectToVisible:rowRect];
}
-@end
+#pragma mark Private
-
-@implementation BDSKMainTableView (Private)
-
- (NSImage *)headerImageForField:(NSString *)field {
static NSDictionary *headerImageCache = nil;
Modified: trunk/bibdesk/BDSKMergeController.m
===================================================================
--- trunk/bibdesk/BDSKMergeController.m 2025-10-20 14:34:30 UTC (rev 29743)
+++ trunk/bibdesk/BDSKMergeController.m 2025-10-20 16:14:23 UTC (rev 29744)
@@ -60,7 +60,7 @@
@end
-@interface BDSKMergeController (BDSKPrivate)
+@interface BDSKMergeController ()
- (void)setupFieldsWithPublication:(BibItem *)mergedPublication;
@end
Modified: trunk/bibdesk/BDSKNotesSearchIndex.m
===================================================================
--- trunk/bibdesk/BDSKNotesSearchIndex.m 2025-10-20 14:34:30 UTC (rev
29743)
+++ trunk/bibdesk/BDSKNotesSearchIndex.m 2025-10-20 16:14:23 UTC (rev
29744)
@@ -46,7 +46,7 @@
#import "BDSKReadWriteLock.h"
-@interface BDSKNotesSearchIndex (BDSKPrivate)
+@interface BDSKNotesSearchIndex ()
- (void)indexItemForIdentifierURL:(NSURL *)identifierURL fileURLs:(NSArray
*)fileURLs removeEmpty:(BOOL)removeEmpty;
- (void)processAddItemNotification:(NSNotification *)note;
Modified: trunk/bibdesk/BDSKNotesWindowController.m
===================================================================
--- trunk/bibdesk/BDSKNotesWindowController.m 2025-10-20 14:34:30 UTC (rev
29743)
+++ trunk/bibdesk/BDSKNotesWindowController.m 2025-10-20 16:14:23 UTC (rev
29744)
@@ -48,7 +48,7 @@
#define BDSKTouchBarItemIdentifierButtons
@"edu.ucsd.mmccrack.bibdesk.touchbar-item.buttons"
-@interface BDSKNotesWindowController (Private)
+@interface BDSKNotesWindowController ()
- (void)reloadNotes;
@end
Modified: trunk/bibdesk/BDSKOrphanedFilesFinder.m
===================================================================
--- trunk/bibdesk/BDSKOrphanedFilesFinder.m 2025-10-20 14:34:30 UTC (rev
29743)
+++ trunk/bibdesk/BDSKOrphanedFilesFinder.m 2025-10-20 16:14:23 UTC (rev
29744)
@@ -63,7 +63,7 @@
#define BDSKOrphanedFilesWindowFrameAutosaveName @"BDSKOrphanedFilesWindow"
-@interface BDSKOrphanedFilesFinder (Private)
+@interface BDSKOrphanedFilesFinder ()
- (void)refreshOrphanedFiles;
- (void)startAnimationWithStatusMessage:(NSString *)message;
- (void)stopAnimationWithStatusMessage:(NSString *)message;
@@ -431,11 +431,8 @@
return NO;
}
-@end
+#pragma mark Private
-
-@implementation BDSKOrphanedFilesFinder (Private)
-
- (void)refreshOrphanedFiles{
[self startAnimationWithStatusMessage:[NSLocalizedString(@"Looking for
orphaned files", @"Status message") stringByAppendingEllipsis]];
// do the actual work with a zero delay to let the UI update
Modified: trunk/bibdesk/BDSKPubMedParser.m
===================================================================
--- trunk/bibdesk/BDSKPubMedParser.m 2025-10-20 14:34:30 UTC (rev 29743)
+++ trunk/bibdesk/BDSKPubMedParser.m 2025-10-20 16:14:23 UTC (rev 29744)
@@ -46,10 +46,9 @@
#import "CFString_BDSKExtensions.h"
-@interface BDSKPubMedParser (Private)
+@interface BDSKPubMedParser ()
+ (void)addString:(NSMutableString *)value toDictionary:(NSMutableDictionary
*)pubDict forTag:(NSString *)tag;
+ (NSString *)pubTypeFromDictionary:(NSDictionary *)pubDict;
-+ (NSString *)stringByFixingInputString:(NSString *)inputString;
+ (void)fixPublicationDictionary:(NSMutableDictionary *)pubDict;
@end
Modified: trunk/bibdesk/BDSKPublicationsArray.m
===================================================================
--- trunk/bibdesk/BDSKPublicationsArray.m 2025-10-20 14:34:30 UTC (rev
29743)
+++ trunk/bibdesk/BDSKPublicationsArray.m 2025-10-20 16:14:23 UTC (rev
29744)
@@ -51,7 +51,7 @@
- (instancetype)initTemporaryWithArray:(NSArray *)anArray
itemsForCiteKey:(NSMapTable *)citeKeyMapTable itemsForCrossrefs:(NSMapTable
*)crossrefMapTable NS_DESIGNATED_INITIALIZER;
@end
-@interface BDSKPublicationsArray (Private)
+@interface BDSKPublicationsArray ()
- (void)addItem:(BibItem *)item forCiteKey:(NSString *)key;
- (void)removeItem:(BibItem *)item forCiteKey:(NSString *)key;
- (void)addItem:(BibItem *)item forCrossref:(NSString *)key;
@@ -325,11 +325,8 @@
[super observeValueForKeyPath:keyPath ofObject:object change:change
context:context];
}
-@end
+#pragma mark Private
-
-@implementation BDSKPublicationsArray (Private)
-
- (void)addItem:(BibItem *)item forCiteKey:(NSString *)key{
NSMutableArray *array = [itemsForCiteKeys objectForKey:key];
if (array) {
Modified: trunk/bibdesk/BDSKRISParser.m
===================================================================
--- trunk/bibdesk/BDSKRISParser.m 2025-10-20 14:34:30 UTC (rev 29743)
+++ trunk/bibdesk/BDSKRISParser.m 2025-10-20 16:14:23 UTC (rev 29744)
@@ -46,7 +46,7 @@
#import "CFString_BDSKExtensions.h"
-@interface BDSKRISParser (Private)
+@interface BDSKRISParser ()
+ (void)addString:(NSMutableString *)value toDictionary:(NSMutableDictionary
*)pubDict forTag:(NSString *)tag forType:(NSString *)pubType;
+ (NSString *)stringByFixingInputString:(NSString *)inputString;
+ (void)fixPublicationDictionary:(NSMutableDictionary *)pubDict;
Modified: trunk/bibdesk/BDSKScriptGroup.m
===================================================================
--- trunk/bibdesk/BDSKScriptGroup.m 2025-10-20 14:34:30 UTC (rev 29743)
+++ trunk/bibdesk/BDSKScriptGroup.m 2025-10-20 16:14:23 UTC (rev 29744)
@@ -61,7 +61,7 @@
#define BDSKScriptGroupRunLoopMode @"BDSKScriptGroupRunLoopMode"
-@interface BDSKScriptGroup (BDSKPrivate)
+@interface BDSKScriptGroup ()
- (void)handleApplicationWillTerminate:(NSNotification *)aNotification;
Modified: trunk/bibdesk/BDSKScrollableTextFieldCell.m
===================================================================
--- trunk/bibdesk/BDSKScrollableTextFieldCell.m 2025-10-20 14:34:30 UTC (rev
29743)
+++ trunk/bibdesk/BDSKScrollableTextFieldCell.m 2025-10-20 16:14:23 UTC (rev
29744)
@@ -48,7 +48,7 @@
#define ENABLED_ALPHA 0.4
#define DISABLED_ALPHA 0.2
-@interface BDSKScrollableTextFieldCell (BDSKPrivate)
+@interface BDSKScrollableTextFieldCell ()
- (void)updateScroll;
@end
Modified: trunk/bibdesk/BDSKSearchBookmarkController.m
===================================================================
--- trunk/bibdesk/BDSKSearchBookmarkController.m 2025-10-20 14:34:30 UTC
(rev 29743)
+++ trunk/bibdesk/BDSKSearchBookmarkController.m 2025-10-20 16:14:23 UTC
(rev 29744)
@@ -74,7 +74,7 @@
static char BDSKSearchBookmarkPropertiesObservationContext;
-@interface BDSKSearchBookmarkController (BDSKPrivate)
+@interface BDSKSearchBookmarkController ()
- (void)setupToolbar;
- (void)endEditing;
- (void)startObservingBookmarks:(NSArray *)newBookmarks;
Modified: trunk/bibdesk/BDSKSpringerParser.m
===================================================================
--- trunk/bibdesk/BDSKSpringerParser.m 2025-10-20 14:34:30 UTC (rev 29743)
+++ trunk/bibdesk/BDSKSpringerParser.m 2025-10-20 16:14:23 UTC (rev 29744)
@@ -49,13 +49,6 @@
#import <AGRegex/AGRegex.h>
-// does the rest actually still work?
-// was for path = /contents/...
-@interface BDSKSpringerParser (BDSKPrivate)
-+ (BibItem *)newItemFromDocument:(DOMDocument *)domDocument fromURL:(NSURL
*)url error:(NSError **)outError;
-@end
-
-
@implementation BDSKSpringerParser
+ (BOOL)canParseDocument:(DOMDocument *)domDocument fromURL:(NSURL *)url {
Modified: trunk/bibdesk/BDSKStringEncodingManager.m
===================================================================
--- trunk/bibdesk/BDSKStringEncodingManager.m 2025-10-20 14:34:30 UTC (rev
29743)
+++ trunk/bibdesk/BDSKStringEncodingManager.m 2025-10-20 16:14:23 UTC (rev
29744)
@@ -53,7 +53,7 @@
#pragma mark -
-@interface BDSKEncodingPopUpButton (BDSKPrivate)
+@interface BDSKEncodingPopUpButton ()
- (void)chooseItem:(id)sender;
- (void)handleEncodingsListChanged:(NSNotification *)notification;
@end
@@ -177,10 +177,6 @@
#pragma mark -
-@interface BDSKStringEncodingManager (BDSKPrivate)
-- (void)setupEncodingsList;
-@end
-
@implementation BDSKStringEncodingManager
@synthesize tableView;
Modified: trunk/bibdesk/BDSKTask.m
===================================================================
--- trunk/bibdesk/BDSKTask.m 2025-10-20 14:34:30 UTC (rev 29743)
+++ trunk/bibdesk/BDSKTask.m 2025-10-20 16:14:23 UTC (rev 29744)
@@ -44,7 +44,7 @@
#import <sys/resource.h>
#import <pthread.h>
-@interface BDSKTask (Private)
+@interface BDSKTask ()
+ (void)_watchQueue;
- (void)_taskSignaled;
@@ -486,10 +486,8 @@
}
}
-@end
+#pragma mark Private
-@implementation BDSKTask (Private)
-
+ (void)_watchQueue
{
do {
Modified: trunk/bibdesk/BDSKTemplate.m
===================================================================
--- trunk/bibdesk/BDSKTemplate.m 2025-10-20 14:34:30 UTC (rev 29743)
+++ trunk/bibdesk/BDSKTemplate.m 2025-10-20 16:14:23 UTC (rev 29744)
@@ -109,7 +109,7 @@
return [templateAttributedString attributedSubstringFromRange:range];
}
-@interface BDSKTemplate (BDSKPrivate)
+@interface BDSKTemplate ()
+ (void)addDefaultPreviewTemplateIfNeeded;
@end
Modified: trunk/bibdesk/BDSKTemplateDocument.m
===================================================================
--- trunk/bibdesk/BDSKTemplateDocument.m 2025-10-20 14:34:30 UTC (rev
29743)
+++ trunk/bibdesk/BDSKTemplateDocument.m 2025-10-20 16:14:23 UTC (rev
29744)
@@ -78,7 +78,7 @@
@interface BDSKValueOrNoneTransformer : NSValueTransformer @end
-@interface BDSKTemplateDocument (BDSKPrivate)
+@interface BDSKTemplateDocument ()
- (NSArray *)tokensForFields:(NSArray *)array;
- (BDSKTypeTemplate *)addTypeTemplateForType:(NSString *)type;
- (void)updateTextViews;
@@ -85,8 +85,6 @@
- (void)updateStrings;
- (void)updateOptionView;
- (void)handleDidChangeSelectionNotification:(NSNotification *)notification;
-- (void)handleTokenDidChangeNotification:(NSNotification *)notification;
-- (void)handleTemplateDidChangeNotification:(NSNotification *)notification;
- (NSDictionary *)convertPubTemplate:(NSArray *)templateArray
defaultFont:(NSFont *)defaultFont;
- (void)startObservingTypeTemplate:(BDSKTypeTemplate *)typeTemplate;
- (void)stopObservingTypeTemplate:(BDSKTypeTemplate *)typeTemplate;
Modified: trunk/bibdesk/BDSKTypeSelectHelper.m
===================================================================
--- trunk/bibdesk/BDSKTypeSelectHelper.m 2025-10-20 14:34:30 UTC (rev
29743)
+++ trunk/bibdesk/BDSKTypeSelectHelper.m 2025-10-20 16:14:23 UTC (rev
29744)
@@ -50,7 +50,7 @@
@end
-@interface BDSKTypeSelectHelper (BDSKPrivate)
+@interface BDSKTypeSelectHelper ()
- (NSArray *)searchCache;
- (void)searchWithStickyMatch:(BOOL)allowUpdate;
- (void)stopTimer;
@@ -219,11 +219,8 @@
return [keyEvent deviceIndependentModifierFlags] == 0 && [keyEvent
firstCharacter] == CANCEL_CHARACTER;
}
-@end
+#pragma mark BDSKPrivate
-
-@implementation BDSKTypeSelectHelper (BDSKPrivate)
-
- (NSTextView *)editor {
static NSTextView *editor = nil;
if (editor == nil) {
Modified: trunk/bibdesk/BDSKWebGroup.m
===================================================================
--- trunk/bibdesk/BDSKWebGroup.m 2025-10-20 14:34:30 UTC (rev 29743)
+++ trunk/bibdesk/BDSKWebGroup.m 2025-10-20 16:14:23 UTC (rev 29744)
@@ -64,7 +64,7 @@
@interface BDSKWebGroup () <BDSKWebParserDelegate>
@end
-@interface BDSKWebGroup (BDSKPrivate)
+@interface BDSKWebGroup ()
- (void)setObject:(id)object forKey:(NSString *)key forFrame:(WebFrame *)frame;
- (BOOL)getInfo:(NSMutableDictionary **)infoPtr publications:(NSMutableArray
**)pubsPtr andFrame:(WebFrame **)framePtr forParser:(BDSKWebParser *)parser;
@end
@@ -340,12 +340,8 @@
[self notifyUpdate];
}
-@end
+#pragma mark Private
-#pragma mark -
-
-@implementation BDSKWebGroup (BDSKPrivate)
-
- (void)setObject:(id)object forKey:(NSString *)key forFrame:(WebFrame *)frame
{
NSMutableDictionary *info = [frameInfo objectForKey:frame];
if (info == nil) {
Modified: trunk/bibdesk/BDSKZoomablePDFView.m
===================================================================
--- trunk/bibdesk/BDSKZoomablePDFView.m 2025-10-20 14:34:30 UTC (rev 29743)
+++ trunk/bibdesk/BDSKZoomablePDFView.m 2025-10-20 16:14:23 UTC (rev 29744)
@@ -49,7 +49,7 @@
@end
-@interface BDSKZoomablePDFView (BDSKPrivate)
+@interface BDSKZoomablePDFView ()
- (void)makeScalePopUpButton;
- (void)scalePopUpAction:(id)sender;
Modified: trunk/bibdesk/BDSKZoomableTextView.m
===================================================================
--- trunk/bibdesk/BDSKZoomableTextView.m 2025-10-20 14:34:30 UTC (rev
29743)
+++ trunk/bibdesk/BDSKZoomableTextView.m 2025-10-20 16:14:23 UTC (rev
29744)
@@ -42,7 +42,7 @@
#import "NSObject_BDSKExtensions.h"
-@interface BDSKZoomableTextView (BDSKPrivate)
+@interface BDSKZoomableTextView ()
- (void)makeScalePopUpButton;
- (void)scalePopUpAction:(id)sender;
Modified: trunk/bibdesk/BibAuthor.m
===================================================================
--- trunk/bibdesk/BibAuthor.m 2025-10-20 14:34:30 UTC (rev 29743)
+++ trunk/bibdesk/BibAuthor.m 2025-10-20 16:14:23 UTC (rev 29744)
@@ -46,7 +46,7 @@
#define BDSKMatchAuthorNamesExactlyKey @"BDSKMatchAuthorNamesExactly"
-@interface BibAuthor (Private)
+@interface BibAuthor ()
- (void)setupNames;
- (void)setupAbbreviatedNames;
@@ -359,10 +359,8 @@
return [person vCardRepresentation];
}
-@end
+#pragma mark Private
-@implementation BibAuthor (Private)
-
- (void)setupNames{
NSParameterAssert(originalName != nil);
Modified: trunk/bibdesk/BibPref_AutoFile.m
===================================================================
--- trunk/bibdesk/BibPref_AutoFile.m 2025-10-20 14:34:30 UTC (rev 29743)
+++ trunk/bibdesk/BibPref_AutoFile.m 2025-10-20 16:14:23 UTC (rev 29744)
@@ -51,12 +51,11 @@
#define MAX_PREVIEW_WIDTH 501.0
#define MAX_FORMAT_WIDTH 288.0
-@interface BibPref_AutoFile (Private)
+@interface BibPref_AutoFile ()
- (NSString *)formatError;
- (void)setLocalUrlFormatInvalidWarning:(NSString *)message;
- (void)updateFormatPresetUI;
- (void)updateFormatPreviewUI;
-- (void)handleFormatSelectionDidChange:(NSNotification *)notification;
@end
Modified: trunk/bibdesk/BibPref_Cite.m
===================================================================
--- trunk/bibdesk/BibPref_Cite.m 2025-10-20 14:34:30 UTC (rev 29743)
+++ trunk/bibdesk/BibPref_Cite.m 2025-10-20 16:14:23 UTC (rev 29744)
@@ -44,7 +44,7 @@
#define BDSKIsTemplateTransformerName @"BDSKIsTemplate"
-@interface BibPref_Cite (Private)
+@interface BibPref_Cite ()
- (void)updateTemplates;
- (void)updateCiteCommandUI;
- (void)handleExportTemplatesChanged:(NSNotification *)notification;
Modified: trunk/bibdesk/BibPref_CiteKey.m
===================================================================
--- trunk/bibdesk/BibPref_CiteKey.m 2025-10-20 14:34:30 UTC (rev 29743)
+++ trunk/bibdesk/BibPref_CiteKey.m 2025-10-20 16:14:23 UTC (rev 29744)
@@ -52,12 +52,11 @@
#define MAX_FORMAT_WIDTH 266
-@interface BibPref_CiteKey (Private)
+@interface BibPref_CiteKey ()
- (NSString *)formatError;
- (void)setCiteKeyFormatInvalidWarning:(NSString *)message;
- (void)updateFormatPresetUI;
- (void)updateFormatPreviewUI;
-- (void)handleFormatSelectionDidChange:(NSNotification *)notification;
@end
Modified: trunk/bibdesk/BibPref_Crossref.m
===================================================================
--- trunk/bibdesk/BibPref_Crossref.m 2025-10-20 14:34:30 UTC (rev 29743)
+++ trunk/bibdesk/BibPref_Crossref.m 2025-10-20 16:14:23 UTC (rev 29744)
@@ -42,7 +42,7 @@
#import "NSTableView_BDSKExtensions.h"
-@interface BibPref_Crossref (Private)
+@interface BibPref_Crossref ()
- (void)updateAddRemoveButton;
- (void)updateDuplicateTypes;
@end
Modified: trunk/bibdesk/BibPref_Export.m
===================================================================
--- trunk/bibdesk/BibPref_Export.m 2025-10-20 14:34:30 UTC (rev 29743)
+++ trunk/bibdesk/BibPref_Export.m 2025-10-20 16:14:23 UTC (rev 29744)
@@ -51,7 +51,7 @@
#define BDSKPasteboardTypeTemplateRows
@"edu.ucsd.mmccrack.bibdesk.pasteboard.template-rows"
-@interface BibPref_Export (Private)
+@interface BibPref_Export ()
- (void)updateUI;
- (void)synchronizePrefs;
- (void)setItemNodes:(NSArray *)array;
Modified: trunk/bibdesk/BibPref_Sharing.m
===================================================================
--- trunk/bibdesk/BibPref_Sharing.m 2025-10-20 14:34:30 UTC (rev 29743)
+++ trunk/bibdesk/BibPref_Sharing.m 2025-10-20 16:14:23 UTC (rev 29744)
@@ -45,7 +45,7 @@
static char BDSKSharingServerObservationContext;
-@interface BibPref_Sharing (Private)
+@interface BibPref_Sharing ()
- (void)handleComputerNameChanged:(NSNotification *)aNotification;
- (void)updateSharingUI;
@end
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Bibdesk-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bibdesk-commit
