Revision: 29871
          http://sourceforge.net/p/bibdesk/svn/29871
Author:   hofman
Date:     2025-11-22 10:40:09 +0000 (Sat, 22 Nov 2025)
Log Message:
-----------
Add some more lightweight generics

Modified Paths:
--------------
    trunk/bibdesk/BDSKBibTeXParser.h
    trunk/bibdesk/BDSKButtonBar.h
    trunk/bibdesk/BDSKCondition+Scripting.h
    trunk/bibdesk/BDSKEdgeView.h
    trunk/bibdesk/BDSKFieldCollection.h
    trunk/bibdesk/BDSKFieldEditor.h
    trunk/bibdesk/BDSKFilter.h
    trunk/bibdesk/BDSKGroup.h
    trunk/bibdesk/BDSKGroupsArray.h
    trunk/bibdesk/BDSKOrphanedFilesFinder.h
    trunk/bibdesk/BDSKSearchBookmark+Scripting.h
    trunk/bibdesk/BDSKSearchBookmark.h
    trunk/bibdesk/BDSKSearchGroup.h
    trunk/bibdesk/BDSKStatusBar.h
    trunk/bibdesk/BDSKStatusBar.m
    trunk/bibdesk/BDSKTemplateParser.h
    trunk/bibdesk/BDSKTypeManager.h
    trunk/bibdesk/BibDocument.h
    trunk/bibdesk/BibDocument_DataSource.h
    trunk/bibdesk/BibItem.h
    trunk/bibdesk/BibItem.m
    trunk/bibdesk/NSError_BDSKExtensions.h

Modified: trunk/bibdesk/BDSKBibTeXParser.h
===================================================================
--- trunk/bibdesk/BDSKBibTeXParser.h    2025-11-21 23:47:07 UTC (rev 29870)
+++ trunk/bibdesk/BDSKBibTeXParser.h    2025-11-22 10:40:09 UTC (rev 29871)
@@ -126,7 +126,7 @@
 */
 + (NSArray<BibAuthor *> *)authorsFromBibtexString:(NSString *)aString 
withPublication:(BibItem *)pub forField:(NSString *)field reuse:(nullable 
NSArray<BibAuthor *> *)oldAuthors;
 
-+ (NSDictionary *)nameComponents:(NSString *)aName forPublication:(BibItem 
*)pub;
++ (NSDictionary<NSString *, NSString *> *)nameComponents:(NSString *)aName 
forPublication:(BibItem *)pub;
 
 @end
 

Modified: trunk/bibdesk/BDSKButtonBar.h
===================================================================
--- trunk/bibdesk/BDSKButtonBar.h       2025-11-21 23:47:07 UTC (rev 29870)
+++ trunk/bibdesk/BDSKButtonBar.h       2025-11-22 10:40:09 UTC (rev 29871)
@@ -43,8 +43,8 @@
 @class BDSKImagePopUpButton;
 
 @interface BDSKButtonBar : NSView {
-    NSMutableArray *buttons;
-    NSMutableArray *cachededButtons;
+    NSMutableArray<NSButton *> *buttons;
+    NSMutableArray<NSButton *> *cachededButtons;
     NSButton *addButton;
     NSButton *removeButton;
     BOOL hasAddButton, hasRemoveButton;

Modified: trunk/bibdesk/BDSKCondition+Scripting.h
===================================================================
--- trunk/bibdesk/BDSKCondition+Scripting.h     2025-11-21 23:47:07 UTC (rev 
29870)
+++ trunk/bibdesk/BDSKCondition+Scripting.h     2025-11-22 10:40:09 UTC (rev 
29871)
@@ -43,7 +43,7 @@
 
 @interface BDSKCondition (Scripting)
 
-- (instancetype)initWithScriptingProperties:(NSDictionary *)properties;
+- (instancetype)initWithScriptingProperties:(NSDictionary<NSString *, id> 
*)properties;
 
 @property (nonatomic, readonly) NSString *scriptingKey;
 @property (nonatomic, readonly) NSInteger scriptingComparison;

Modified: trunk/bibdesk/BDSKEdgeView.h
===================================================================
--- trunk/bibdesk/BDSKEdgeView.h        2025-11-21 23:47:07 UTC (rev 29870)
+++ trunk/bibdesk/BDSKEdgeView.h        2025-11-22 10:40:09 UTC (rev 29871)
@@ -52,8 +52,8 @@
 @interface BDSKEdgeView : NSView {
     NSView *contentView;
        BDSKRectEdges edges;
-       NSMutableArray *edgeColors;
-    NSArray *backgroundColors;
+       NSMutableArray<NSColor *> *edgeColors;
+    NSArray<NSColor *> *backgroundColors;
     NSView *backgroundView;
     BOOL wantsSubviews;
     BOOL relectViewEnabled;

Modified: trunk/bibdesk/BDSKFieldCollection.h
===================================================================
--- trunk/bibdesk/BDSKFieldCollection.h 2025-11-21 23:47:07 UTC (rev 29870)
+++ trunk/bibdesk/BDSKFieldCollection.h 2025-11-22 10:40:09 UTC (rev 29871)
@@ -52,7 +52,7 @@
 
 @interface BDSKFieldCollection : NSObject {
     __weak BibItem *item;
-    NSMutableSet *usedFields;
+    NSMutableSet<NSString *> *usedFields;
     BDSKFieldCollectionType type;
 }
 

Modified: trunk/bibdesk/BDSKFieldEditor.h
===================================================================
--- trunk/bibdesk/BDSKFieldEditor.h     2025-11-21 23:47:07 UTC (rev 29870)
+++ trunk/bibdesk/BDSKFieldEditor.h     2025-11-22 10:40:09 UTC (rev 29871)
@@ -52,7 +52,7 @@
 
 
 @interface BDSKFieldEditor : NSTextView {
-       NSMutableArray *delegatedDraggedTypes;
+       NSMutableArray<NSString *> *delegatedDraggedTypes;
     BOOL isEditing;
     BOOL isAutoComplete;
     BOOL isCompleting;

Modified: trunk/bibdesk/BDSKFilter.h
===================================================================
--- trunk/bibdesk/BDSKFilter.h  2025-11-21 23:47:07 UTC (rev 29870)
+++ trunk/bibdesk/BDSKFilter.h  2025-11-22 10:40:09 UTC (rev 29871)
@@ -59,7 +59,7 @@
 - (instancetype)initWithDictionary:(NSDictionary<NSString *, id> *)dictionary;
 - (instancetype)initWithCoder:(NSCoder *)coder NS_DESIGNATED_INITIALIZER;
 
-@property (nonatomic, readonly) NSDictionary *dictionaryValue;
+@property (nonatomic, readonly) NSDictionary<NSString *, id> *dictionaryValue;
 
 - (BOOL)testItem:(BibItem *)item;
 

Modified: trunk/bibdesk/BDSKGroup.h
===================================================================
--- trunk/bibdesk/BDSKGroup.h   2025-11-21 23:47:07 UTC (rev 29870)
+++ trunk/bibdesk/BDSKGroup.h   2025-11-22 10:40:09 UTC (rev 29871)
@@ -87,7 +87,7 @@
 
 - (instancetype)initWithCoder:(NSCoder *)decoder NS_DESIGNATED_INITIALIZER;
 
-@property (nonatomic, readonly) NSDictionary *dictionaryValue;
+@property (nonatomic, readonly) NSDictionary<NSString *, id> *dictionaryValue;
 
 @property (nonatomic, readonly) NSString *uniqueID;
 

Modified: trunk/bibdesk/BDSKGroupsArray.h
===================================================================
--- trunk/bibdesk/BDSKGroupsArray.h     2025-11-21 23:47:07 UTC (rev 29870)
+++ trunk/bibdesk/BDSKGroupsArray.h     2025-11-22 10:40:09 UTC (rev 29871)
@@ -47,7 +47,7 @@
 @class BDSKGroup, BDSKLibraryGroup, BDSKLastImportGroup, BDSKSmartGroup, 
BDSKStaticGroup, BDSKCategoryGroup, BDSKURLGroup, BDSKScriptGroup, 
BDSKSearchGroup, BDSKWebGroup, BDSKSharedGroup, BDSKLibraryParentGroup, 
BDSKExternalParentGroup, BDSKSmartParentGroup, BDSKStaticParentGroup, 
BDSKCategoryParentGroup, BibDocument;
 
 @interface BDSKGroupsArray : NSArray<BDSKParentGroup *> {
-    NSMutableArray *groups;
+    NSMutableArray<__kindof BDSKParentGroup *> *groups;
     __weak BibDocument *document;
 }
 

Modified: trunk/bibdesk/BDSKOrphanedFilesFinder.h
===================================================================
--- trunk/bibdesk/BDSKOrphanedFilesFinder.h     2025-11-21 23:47:07 UTC (rev 
29870)
+++ trunk/bibdesk/BDSKOrphanedFilesFinder.h     2025-11-22 10:40:09 UTC (rev 
29871)
@@ -53,7 +53,7 @@
     NSTextField *statusField;
     NSMenu *contextMenu;
     NSButton *matchButton;
-    NSMutableArray *orphanedFiles;
+    NSMutableArray<NSURL *> *orphanedFiles;
     NSString *searchString;
     BOOL showsMatches;
     BOOL wasLaunched;

Modified: trunk/bibdesk/BDSKSearchBookmark+Scripting.h
===================================================================
--- trunk/bibdesk/BDSKSearchBookmark+Scripting.h        2025-11-21 23:47:07 UTC 
(rev 29870)
+++ trunk/bibdesk/BDSKSearchBookmark+Scripting.h        2025-11-22 10:40:09 UTC 
(rev 29871)
@@ -43,7 +43,7 @@
 
 @interface BDSKSearchBookmark (Scripting)
 
-@property (nonatomic, readonly) NSDictionary *scriptingServerInfo;
+@property (nonatomic, readonly) NSDictionary<NSString *, id> 
*scriptingServerInfo;
 
 @property (nonatomic, nullable, readonly) NSString *scriptingSearchTerm;
 

Modified: trunk/bibdesk/BDSKSearchBookmark.h
===================================================================
--- trunk/bibdesk/BDSKSearchBookmark.h  2025-11-21 23:47:07 UTC (rev 29870)
+++ trunk/bibdesk/BDSKSearchBookmark.h  2025-11-22 10:40:09 UTC (rev 29871)
@@ -54,7 +54,7 @@
 - (nullable instancetype)initFolderWithLabel:(nullable NSString *)aLabel;
 - (nullable instancetype)initRootWithChildrenDictionaries:(nullable 
NSArray<NSDictionary<NSString *, id> *> *)dictionaries;
 - (nullable instancetype)initSeparator;
-- (nullable instancetype)initWithInfo:(NSDictionary *)aDictionary 
label:(nullable NSString *)aLabel;
+- (nullable instancetype)initWithInfo:(NSDictionary<NSString *, id> 
*)aDictionary label:(nullable NSString *)aLabel;
 - (nullable instancetype)initWithDictionary:(NSDictionary<NSString *, id> 
*)dictionary;
 
 @property (nonatomic, readonly) NSDictionary<NSString *, id> *dictionaryValue;

Modified: trunk/bibdesk/BDSKSearchGroup.h
===================================================================
--- trunk/bibdesk/BDSKSearchGroup.h     2025-11-21 23:47:07 UTC (rev 29870)
+++ trunk/bibdesk/BDSKSearchGroup.h     2025-11-22 10:40:09 UTC (rev 29871)
@@ -92,7 +92,7 @@
 
 @property (nonatomic, nullable, readonly) NSFormatter *searchStringFormatter;
 
-+ (NSDictionary *)dictionaryWithBdsksearchURL:(NSURL *)bdsksearchURL;
++ (NSDictionary<NSString *, id> *)dictionaryWithBdsksearchURL:(NSURL 
*)bdsksearchURL;
 
 @end
 

Modified: trunk/bibdesk/BDSKStatusBar.h
===================================================================
--- trunk/bibdesk/BDSKStatusBar.h       2025-11-21 23:47:07 UTC (rev 29870)
+++ trunk/bibdesk/BDSKStatusBar.h       2025-11-22 10:40:09 UTC (rev 29871)
@@ -53,6 +53,7 @@
 - (nullable NSString *)statusBar:(BDSKStatusBar *)statusBar 
toolTipForIdentifier:(NSString *)identifier;
 @end
 
+@class BDSKStatusBarIcon;
 
 @interface BDSKStatusBar : NSView {
        id textCell;
@@ -59,7 +60,7 @@
     NSTextField *textField;
        NSImageCell *iconCell;
        NSProgressIndicator *progressIndicator;
-       NSMutableArray *icons;
+       NSMutableArray<BDSKStatusBarIcon *> *icons;
     NSLayoutConstraint *leadingConstraint;
     NSLayoutConstraint *trailingConstraint;
     NSLayoutConstraint *bottomConstraint;

Modified: trunk/bibdesk/BDSKStatusBar.m
===================================================================
--- trunk/bibdesk/BDSKStatusBar.m       2025-11-21 23:47:07 UTC (rev 29870)
+++ trunk/bibdesk/BDSKStatusBar.m       2025-11-22 10:40:09 UTC (rev 29871)
@@ -417,7 +417,7 @@
 }
 
 - (NSArray *)accessibilityChildren {
-    return NSAccessibilityUnignoredChildren([[self subviews] 
arrayByAddingObjectsFromArray:icons]);
+    return NSAccessibilityUnignoredChildren([(NSArray *)[self subviews] 
arrayByAddingObjectsFromArray:icons]);
 }
 
 - (NSString *)accessibilityLabel {

Modified: trunk/bibdesk/BDSKTemplateParser.h
===================================================================
--- trunk/bibdesk/BDSKTemplateParser.h  2025-11-21 23:47:07 UTC (rev 29870)
+++ trunk/bibdesk/BDSKTemplateParser.h  2025-11-22 10:40:09 UTC (rev 29871)
@@ -74,7 +74,7 @@
 @property (nonatomic, readonly, getter=isNotEmpty) BOOL notEmpty;
 
 @property (nonatomic, readonly) NSString *templateStringValue;
-- (NSAttributedString 
*)templateAttributedStringValueWithAttributes:(NSDictionary *)attributes;
+- (NSAttributedString 
*)templateAttributedStringValueWithAttributes:(NSDictionary<NSString *, id> 
*)attributes;
 
 @end
 

Modified: trunk/bibdesk/BDSKTypeManager.h
===================================================================
--- trunk/bibdesk/BDSKTypeManager.h     2025-11-21 23:47:07 UTC (rev 29870)
+++ trunk/bibdesk/BDSKTypeManager.h     2025-11-22 10:40:09 UTC (rev 29871)
@@ -75,7 +75,7 @@
     NSDictionary<NSString *, NSString *> *bibTeXTypeForReferTypeDict;
     NSDictionary<NSString *, NSString *> *referTypeForBibTeXTypeDict;
     NSDictionary<NSString *, NSString *> *bibTeXTypeForHCiteTypeDict;
-       NSDictionary<NSString *, NSDictionary<NSString *, NSString *> *> 
*MODSGenresForBibTeXTypeDict;
+       NSDictionary<NSString *, NSDictionary<NSString *, NSArray<NSString *> 
*> *> *MODSGenresForBibTeXTypeDict;
     NSDictionary<NSString *, NSDictionary<NSString *, NSArray<NSString *> *> 
*> *defaultFieldsForTypes;
     NSMutableDictionary<NSString *, NSArray<NSString *> *> 
*standardFieldsForTypes;
        NSArray<NSString *> *defaultTypes;
@@ -168,8 +168,8 @@
 - (NSString *)referTypeForBibTeXType:(NSString *)type;
 
 // MARC
-- (NSDictionary *)fieldNamesForMARCTag:(NSString *)name;
-- (NSDictionary *)fieldNamesForUNIMARCTag:(NSString *)name;
+- (NSDictionary<NSString *, NSString *> *)fieldNamesForMARCTag:(NSString 
*)name;
+- (NSDictionary<NSString *, NSString *> *)fieldNamesForUNIMARCTag:(NSString 
*)name;
 
 // JSTOR
 - (NSString *)fieldNameForJSTORTag:(NSString *)tag;
@@ -188,7 +188,7 @@
 - (NSString *)bibTeXTypeForHCiteType:(NSString *)type;
 
 // MODS
-- (NSDictionary *)MODSGenresForBibTeXType:(NSString *)type;
+- (NSDictionary<NSString *, NSArray<NSString *> *> 
*)MODSGenresForBibTeXType:(NSString *)type;
 
 // Character sets for format parsing and group splitting
 - (NSCharacterSet *)invalidCharactersForField:(NSString *)fieldName;

Modified: trunk/bibdesk/BibDocument.h
===================================================================
--- trunk/bibdesk/BibDocument.h 2025-11-21 23:47:07 UTC (rev 29870)
+++ trunk/bibdesk/BibDocument.h 2025-11-22 10:40:09 UTC (rev 29871)
@@ -45,7 +45,7 @@
 
 NS_ASSUME_NONNULL_BEGIN
 
-@class BibItem, BibAuthor, BDSKGroup, BDSKStaticGroup, BDSKSmartGroup, 
BDSKTemplate, BDSKPublicationsArray, BDSKGroupsArray;
+@class BibItem, BibAuthor, BDSKGroup, BDSKStaticGroup, BDSKSmartGroup, 
BDSKTemplate, BDSKPublicationsArray, BDSKGroupsArray, BDSKFileViewObject;
 @class AGRegex, BDSKMacroResolver;
 @class BDSKEditor, BDSKMacroWindowController, 
BDSKDocumentInfoWindowController, BDSKPreviewer, 
BDSKFileContentSearchController, BDSKCustomCiteDrawerController, 
BDSKSearchGroupViewController, BDSKSaveAccessoryViewController;
 @class BDSKStatusBar, BDSKButtonBar, BDSKMainTableView, BDSKGroupOutlineView, 
BDSKEdgeView, BDSKImagePopUpButton, BDSKColoredView, BDSKEncodingPopUpButton, 
BDSKZoomablePDFView, FVFileView, BDSKSplitView, BDSKColorLabelWell;
@@ -146,7 +146,7 @@
     NSLayoutConstraint *controlContentViewTopConstraint;
     NSLayoutConstraint *controlContentViewBottomConstraint;
 
-    NSDictionary *tableColumnWidths;
+    NSDictionary<NSString *, NSNumber *> *tableColumnWidths;
     
     NSTouchBar *touchBar;
     
@@ -158,7 +158,7 @@
     NSPopUpButton *groupAddButton;
     NSView *groupButtonView;
     NSMenu *groupFieldMenu;
-    NSMutableArray *groupSpinners;
+    NSMutableArray<NSProgressIndicator *> *groupSpinners;
     NSLayoutConstraint *groupButtonViewWidthConstraint;
     
 #pragma mark Side preview variables
@@ -190,7 +190,7 @@
     
 #pragma mark Toolbar variables
     
-    NSMutableDictionary *toolbarItems;
+    NSMutableDictionary<NSString *, __kindof NSToolbarItem *> *toolbarItems;
        
     BDSKImagePopUpButton *actionMenuButton;
     BDSKImagePopUpButton *groupActionMenuButton;
@@ -224,13 +224,13 @@
 #pragma mark Publications and Groups variables
 
     BDSKPublicationsArray *publications;  // holds all the publications
-    NSMutableArray *groupedPublications;  // holds publications in the 
selected groups
-    NSMutableArray *shownPublications;    // holds the ones we want to show.
+    NSMutableArray<BibItem *> *groupedPublications;  // holds publications in 
the selected groups
+    NSMutableArray<BibItem *> *shownPublications;    // holds the ones we want 
to show.
     // All display related operations should use shownPublications
    
     BDSKGroupsArray *groups;
     
-    NSMutableArray *shownFiles;
+    NSMutableArray<BDSKFileViewObject *> *shownFiles;
     
     NSDate *openDate;
        
@@ -238,7 +238,7 @@
 
     BDSKMacroResolver *macroResolver;
        
-    NSMapTable *documentInfo;
+    NSMapTable<NSString *, NSString *> *documentInfo;
     
        NSString *frontMatter;    // for preambles, and stuff
        
@@ -292,13 +292,13 @@
     
     NSString *basePath;
     
-    NSDictionary *mainWindowSetupDictionary;
+    NSDictionary<NSString *, id> *mainWindowSetupDictionary;
     
     NSURL *saveTargetURL;
     
     NSInvocation *shouldCloseInvocation;
     
-    NSMutableSet *changedPublications;
+    NSMutableSet<BibItem *> *changedPublications;
     
     NSArray<NSURL *> *previewURLs;
     
@@ -377,7 +377,7 @@
 
 @property (nonatomic, readonly) BDSKGroupsArray *groups;
 
-@property (nonatomic, copy) NSMapTable *documentInfo;
+@property (nonatomic, copy) NSMapTable<NSString *, NSString *> *documentInfo;
 - (nullable NSString *)documentInfoForKey:(NSString *)key;
 - (void)setDocumentInfo:(NSString *)value forKey:(NSString *)key;
 - (id)valueForUndefinedKey:(NSString *)key;

Modified: trunk/bibdesk/BibDocument_DataSource.h
===================================================================
--- trunk/bibdesk/BibDocument_DataSource.h      2025-11-21 23:47:07 UTC (rev 
29870)
+++ trunk/bibdesk/BibDocument_DataSource.h      2025-11-22 10:40:09 UTC (rev 
29871)
@@ -51,7 +51,7 @@
 - (BOOL)writePublications:(NSArray*)pubs 
forDragCopyType:(BDSKDragCopyType)dragCopyType citeString:(nullable NSString 
*)citeString toPasteboard:(NSPasteboard*)pboard;
 - (NSImage *)dragImageForPromisedItemsUsingCiteString:(nullable NSString 
*)citeString;
 
-@property (nonatomic, readonly) NSDictionary 
*currentTableColumnWidthsAndIdentifiers;
+@property (nonatomic, readonly) NSDictionary<NSString *, NSNumber *> 
*currentTableColumnWidthsAndIdentifiers;
 @property (nonatomic, getter=isDragFromExternalGroups) BOOL 
dragFromExternalGroups;
 
 - (BOOL)selectItemsInAuxFileURL:(NSURL *)auxURL;

Modified: trunk/bibdesk/BibItem.h
===================================================================
--- trunk/bibdesk/BibItem.h     2025-11-21 23:47:07 UTC (rev 29870)
+++ trunk/bibdesk/BibItem.h     2025-11-22 10:40:09 UTC (rev 29871)
@@ -96,16 +96,16 @@
 @interface BibItem : NSObject <NSCopying, NSSecureCoding, BDSKParseableItem, 
BDSKLinkedFileDelegate, BDSKItemDownloadDelegate> {
     NSString *citeKey;
        NSString *pubType;
-    NSMutableDictionary *pubFields;
-    NSMutableDictionary *people;
+    NSMutableDictionary<NSString *, NSString *> *pubFields;
+    NSMutableDictionary<NSString *, NSArray<BibAuthor *> *> *people;
     NSInteger month;
     NSInteger year;
        NSDate *dateAdded;
        NSDate *dateModified;
-       NSMutableDictionary *groups;
-    NSMutableDictionary *URLs;
+       NSMutableDictionary<NSString *, NSHashTable *> *groups;
+    NSMutableDictionary<NSString *, NSURL *> *URLs;
     NSNumber * fileOrder;
-    NSMutableSet *filesToBeFiled;
+    NSMutableSet<BDSKLinkedFile *> *filesToBeFiled;
        __weak id<BDSKOwner> owner;
     BDSKMacroResolver *macroResolver;
     BDSKFieldCollection *templateFields;
@@ -112,8 +112,8 @@
     NSInteger itemIndex;
     CGFloat searchScore;
     NSURL *identifierURL;
-    NSMutableArray *files;
-    NSMutableArray *downloads;
+    NSMutableArray<BDSKLinkedFile *> *files;
+    NSMutableArray<BDSKItemDownload *> *downloads;
     NSString *editedField;
     NSMutableString *editedValue;
     struct _biFlags {

Modified: trunk/bibdesk/BibItem.m
===================================================================
--- trunk/bibdesk/BibItem.m     2025-11-21 23:47:07 UTC (rev 29870)
+++ trunk/bibdesk/BibItem.m     2025-11-22 10:40:09 UTC (rev 29871)
@@ -554,7 +554,7 @@
 
 - (void)rebuildPeopleForField:(NSString *)field{
     if (people != nil) {
-        NSMutableArray *oldPeople = [people objectForKey:field];
+        NSArray *oldPeople = [people objectForKey:field];
         // get the string representation from pubFields
         NSString *personStr = [pubFields objectForKey:field];
         // parse into an array of BibAuthor objects
@@ -3501,7 +3501,7 @@
     if ([field isEqualToString:BDSKColorLabelString])
         field = BDSKColorString;
        BDSKASSERT(field != nil && [field isEqualToString:BDSKPubTypeString] == 
NO);
-       NSSet *groupNames = [groups objectForKey:field];
+       NSHashTable *groupNames = [groups objectForKey:field];
     if([groupNames containsObject:groupName] == NO)
         return BDSKFieldActionIgnore;
        
@@ -3636,7 +3636,7 @@
        BDSKASSERT(field != nil && [field isEqualToString:[newGroup key]]);
     if ([field isEqualToString:BDSKColorLabelString])
         field = BDSKColorString;
-       NSSet *groupNames = [groups objectForKey:field];
+       NSHashTable *groupNames = [groups objectForKey:field];
     if([groupNames containsObject:groupName] == NO)
         return BDSKFieldActionIgnore;
        

Modified: trunk/bibdesk/NSError_BDSKExtensions.h
===================================================================
--- trunk/bibdesk/NSError_BDSKExtensions.h      2025-11-21 23:47:07 UTC (rev 
29870)
+++ trunk/bibdesk/NSError_BDSKExtensions.h      2025-11-22 10:40:09 UTC (rev 
29871)
@@ -82,7 +82,7 @@
 + (instancetype)localErrorWithCode:(NSInteger)code 
localizedDescription:(nullable NSString *)description underlyingError:(nullable 
NSError *)underlyingError;
 
 // returns BibDesk-specific errors that can allow valueForKey: and 
setValue:forKey: usage
-+ (instancetype)mutableErrorWithDomain:(NSString *)domain code:(NSInteger)code 
userInfo:(nullable NSDictionary *)dict;
++ (instancetype)mutableErrorWithDomain:(NSString *)domain code:(NSInteger)code 
userInfo:(nullable NSDictionary<NSString *, id> *)dict;
 + (instancetype)mutableLocalErrorWithCode:(NSInteger)code 
localizedDescription:(nullable NSString *)description;
 + (instancetype)mutableLocalErrorWithCode:(NSInteger)code 
localizedDescription:(nullable NSString *)description underlyingError:(NSError 
*)underlyingError;
 

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.



_______________________________________________
Bibdesk-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bibdesk-commit

Reply via email to