Revision: 29920
http://sourceforge.net/p/bibdesk/svn/29920
Author: hofman
Date: 2025-11-30 18:37:11 +0000 (Sun, 30 Nov 2025)
Log Message:
-----------
rename corresponding variable and parameter
Modified Paths:
--------------
trunk/bibdesk/BDSKItemPasteboardHelper.m
trunk/bibdesk/BDSKPreviewer.m
trunk/bibdesk/BDSKTeXTask.h
trunk/bibdesk/BDSKTeXTask.m
Modified: trunk/bibdesk/BDSKItemPasteboardHelper.m
===================================================================
--- trunk/bibdesk/BDSKItemPasteboardHelper.m 2025-11-30 18:27:28 UTC (rev
29919)
+++ trunk/bibdesk/BDSKItemPasteboardHelper.m 2025-11-30 18:37:11 UTC (rev
29920)
@@ -360,7 +360,7 @@
texTasks = [[NSMutableDictionary alloc] init];
[texTasks setObject:currentTask forKey:[pboard name]];
- [currentTask runWithBibTeXString:bibString citeKeys:citeKeys
generatedType:generatedType];
+ [currentTask runWithBibTeXString:bibString citeKeys:citeKeys
generateType:generatedType];
}
- (void)terminateTeXTasks {
Modified: trunk/bibdesk/BDSKPreviewer.m
===================================================================
--- trunk/bibdesk/BDSKPreviewer.m 2025-11-30 18:27:28 UTC (rev 29919)
+++ trunk/bibdesk/BDSKPreviewer.m 2025-11-30 18:37:11 UTC (rev 29920)
@@ -348,7 +348,7 @@
// this will start the spinning wheel
[self displayPreviewsForState:BDSKPreviewStateWaiting success:YES];
// run the tex task in the background
- [texTask runWithBibTeXString:bibStr citeKeys:citeKeys
generatedType:BDSKGeneratePDF];
+ [texTask runWithBibTeXString:bibStr citeKeys:citeKeys
generateType:BDSKGeneratePDF];
}
}
Modified: trunk/bibdesk/BDSKTeXTask.h
===================================================================
--- trunk/bibdesk/BDSKTeXTask.h 2025-11-30 18:27:28 UTC (rev 29919)
+++ trunk/bibdesk/BDSKTeXTask.h 2025-11-30 18:37:11 UTC (rev 29920)
@@ -74,7 +74,7 @@
@property (nonatomic, nullable, weak) id<BDSKTeXTaskDelegate> delegate;
-- (BOOL)runWithBibTeXString:(NSString *)bibStr citeKeys:(NSArray<NSString *>
*)citeKeys generatedType:(BDSKGenerateType)generatedType;
+- (BOOL)runWithBibTeXString:(NSString *)bibStr citeKeys:(NSArray<NSString *>
*)citeKeys generateType:(BDSKGenerateType)generatedType;
- (void)cancel;
- (void)terminate;
Modified: trunk/bibdesk/BDSKTeXTask.m
===================================================================
--- trunk/bibdesk/BDSKTeXTask.m 2025-11-30 18:27:28 UTC (rev 29919)
+++ trunk/bibdesk/BDSKTeXTask.m 2025-11-30 18:37:11 UTC (rev 29920)
@@ -44,7 +44,7 @@
#import "NSString_BDSKExtensions.h"
#import "BDSKPreferenceController.h"
-enum {
+typedef NS_OPTIONS(NSUInteger, BDSKGeneratedType) {
BDSKGeneratedNoneMask = 0,
BDSKGeneratedAMSRefsLaTeXMask = 1 << BDSKGenerateAMSRefsLaTeX,
BDSKGeneratedLaTeXMask = 1 << BDSKGenerateLaTeX,
@@ -54,11 +54,11 @@
@interface BDSKTaskAndGeneratedType : NSObject {
NSTask *task;
- NSUInteger generatedType;
+ BDSKGeneratedType generatedType;
}
-- (instancetype)initWithTask:(NSTask *)aTask generatedType:(NSUInteger)type
NS_DESIGNATED_INITIALIZER;
+- (instancetype)initWithTask:(NSTask *)aTask
generatedType:(BDSKGeneratedType)type NS_DESIGNATED_INITIALIZER;
@property (nonatomic, readonly) NSTask *task;
-@property (nonatomic, readonly) NSUInteger generatedType;
+@property (nonatomic, readonly) BDSKGeneratedType generatedType;
@end
#pragma mark -
@@ -92,7 +92,7 @@
- (void)removeFilesFromPreviousRun;
-- (void)addTaskForGeneratedType:(NSUInteger)type;
+- (void)addTaskForGeneratedType:(BDSKGeneratedType)type;
- (BOOL)invokePendingTasks;
@@ -179,7 +179,7 @@
#pragma mark TeX Tasks
-- (BOOL)runWithBibTeXString:(NSString *)bibStr citeKeys:(NSArray *)citeKeys
generatedType:(BDSKGenerateType)generatedType{
+- (BOOL)runWithBibTeXString:(NSString *)bibStr citeKeys:(NSArray *)citeKeys
generateType:(BDSKGenerateType)generateType{
static BOOL didCheckTeXPaths = NO;
if (didCheckTeXPaths == NO) {
didCheckTeXPaths = YES;
@@ -188,7 +188,7 @@
generatedDataMask = BDSKGeneratedNoneMask;
- BOOL success = [self writeTeXFileForCiteKeys:citeKeys isLTB:generatedType
== BDSKGenerateAMSRefsLaTeX] && [self writeBibTeXFile:bibStr];
+ BOOL success = [self writeTeXFileForCiteKeys:citeKeys isLTB:generateType
== BDSKGenerateAMSRefsLaTeX] && [self writeBibTeXFile:bibStr];
if (success) {
NSParameterAssert([pendingTasks count] == 0);
@@ -198,8 +198,8 @@
// tasks are launched from the end of pendingTasks, so we add them in
opposite order
// final task generates the requested type, can be pdflatex or bibtex
- [self addTaskForGeneratedType:1 << generatedType];
- if (generatedType == BDSKGeneratePDF) {
+ [self addTaskForGeneratedType:1 << generateType];
+ if (generateType == BDSKGeneratePDF) {
// pdflatex
[self addTaskForGeneratedType:BDSKGeneratedNoneMask];
// bibtex
@@ -387,7 +387,7 @@
[fm removeItemAtPath:path error:NULL];
}
-- (void)addTaskForGeneratedType:(NSUInteger)type {
+- (void)addTaskForGeneratedType:(BDSKGeneratedType)type {
NSString *commandKey = nil;
NSString *extraArg = nil;
@@ -555,7 +555,7 @@
return [self initWithTask:nil generatedType:BDSKGeneratedNoneMask];
}
-- (instancetype)initWithTask:(NSTask *)aTask generatedType:(NSUInteger)type {
+- (instancetype)initWithTask:(NSTask *)aTask
generatedType:(BDSKGeneratedType)type {
self = [super init];
if (self) {
task = aTask;
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Bibdesk-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bibdesk-commit