Revision: 29933
          http://sourceforge.net/p/bibdesk/svn/29933
Author:   hofman
Date:     2025-12-02 16:28:37 +0000 (Tue, 02 Dec 2025)
Log Message:
-----------
no need to implement shared class factorry method for services provider

Modified Paths:
--------------
    trunk/bibdesk/BDSKAppController.m
    trunk/bibdesk/BDSKServiceProvider.h
    trunk/bibdesk/BDSKServiceProvider.m

Modified: trunk/bibdesk/BDSKAppController.m
===================================================================
--- trunk/bibdesk/BDSKAppController.m   2025-12-02 15:57:07 UTC (rev 29932)
+++ trunk/bibdesk/BDSKAppController.m   2025-12-02 16:28:37 UTC (rev 29933)
@@ -408,7 +408,7 @@
     [self checkFormatStrings];
     
     // register services
-    [NSApp setServicesProvider:[BDSKServiceProvider sharedServiceProvider]];
+    [NSApp setServicesProvider:[[BDSKServiceProvider alloc] init]];
     
     // register server for cite key completion
     [BDSKCompletionServer sharedCompletionServer];

Modified: trunk/bibdesk/BDSKServiceProvider.h
===================================================================
--- trunk/bibdesk/BDSKServiceProvider.h 2025-12-02 15:57:07 UTC (rev 29932)
+++ trunk/bibdesk/BDSKServiceProvider.h 2025-12-02 16:28:37 UTC (rev 29933)
@@ -42,8 +42,6 @@
 
 @interface BDSKServiceProvider : NSObject
 
-@property (class, nonatomic, readonly) BDSKServiceProvider 
*sharedServiceProvider;
-
 - (void)completeCitationFromSelection:(NSPasteboard *)pboard 
userData:(nullable NSString *)userData error:(NSString * _Nullable * 
_Nullable)error;
 - (void)completeTextBibliographyFromSelection:(NSPasteboard *)pboard 
userData:(nullable NSString *)userData error:(NSString * _Nullable * 
_Nullable)error;
 - (void)completeRichBibliographyFromSelection:(NSPasteboard *)pboard 
userData:(nullable NSString *)userData error:(NSString * _Nullable * 
_Nullable)error;

Modified: trunk/bibdesk/BDSKServiceProvider.m
===================================================================
--- trunk/bibdesk/BDSKServiceProvider.m 2025-12-02 15:57:07 UTC (rev 29932)
+++ trunk/bibdesk/BDSKServiceProvider.m 2025-12-02 16:28:37 UTC (rev 29933)
@@ -54,19 +54,6 @@
 
 @implementation BDSKServiceProvider
 
-static id sharedServiceProvider = nil;
-
-+ (BDSKServiceProvider *)sharedServiceProvider {
-    if (sharedServiceProvider == nil)
-        sharedServiceProvider = [[self alloc] init];
-    return sharedServiceProvider;
-}
-
-- (instancetype)init {
-    BDSKPRECONDITION(sharedServiceProvider == nil);
-    return [super init];
-}
-
 - (NSDictionary *)constraintsFromString:(NSString *)string{
     NSScanner *scanner;
     NSMutableDictionary *searchConstraints = [NSMutableDictionary dictionary];

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.



_______________________________________________
Bibdesk-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bibdesk-commit

Reply via email to