Revision: 30042
          http://sourceforge.net/p/bibdesk/svn/30042
Author:   hofman
Date:     2026-02-22 17:31:03 +0000 (Sun, 22 Feb 2026)
Log Message:
-----------
don't have to check for inherited value changes for integer or note fields

Modified Paths:
--------------
    trunk/bibdesk/BDSKEditor.m

Modified: trunk/bibdesk/BDSKEditor.m
===================================================================
--- trunk/bibdesk/BDSKEditor.m  2026-02-22 17:22:46 UTC (rev 30041)
+++ trunk/bibdesk/BDSKEditor.m  2026-02-22 17:31:03 UTC (rev 30042)
@@ -2360,7 +2360,7 @@
         [self updateCiteKeyDuplicateWarning];
     }
     else if([changeKey isNoteField]){
-        if(editorFlags.ignoreFieldChange == NO && (newValue || oldValue) && 
inheritedValueChanged == NO) {
+        if(editorFlags.ignoreFieldChange == NO && (newValue || oldValue)) {
             if (currentEditedView && [[currentEditedView identifier] 
isEqualToString:changeKey]) {
                 [currentEditedView setString:newValue ?: @""];
                 // undo actions in the text view are now invalid
@@ -2375,11 +2375,9 @@
         }
     }
        else if([changeKey isIntegerField]){
-        if (inheritedValueChanged == NO){
-            NSUInteger idx = [[collectionView content] 
indexOfObject:changeKey];
-            if (idx != NSNotFound)
-                [[(BDSKEditorCollectionViewItem *)[collectionView 
itemAtIndex:idx] button] setIntegerValue:[publication 
integerValueOfField:changeKey]];
-        }
+        NSUInteger idx = [[collectionView content] indexOfObject:changeKey];
+        if (idx != NSNotFound)
+            [[(BDSKEditorCollectionViewItem *)[collectionView itemAtIndex:idx] 
button] setIntegerValue:[publication integerValueOfField:changeKey]];
        }
     else if (changeKey == nil){
         // all fields are set

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.



_______________________________________________
Bibdesk-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bibdesk-commit

Reply via email to