Revision: 30064
http://sourceforge.net/p/bibdesk/svn/30064
Author: hofman
Date: 2026-02-26 17:10:56 +0000 (Thu, 26 Feb 2026)
Log Message:
-----------
local variable for window
Modified Paths:
--------------
trunk/bibdesk/BDSKEditor.m
Modified: trunk/bibdesk/BDSKEditor.m
===================================================================
--- trunk/bibdesk/BDSKEditor.m 2026-02-26 16:21:51 UTC (rev 30063)
+++ trunk/bibdesk/BDSKEditor.m 2026-02-26 17:10:56 UTC (rev 30064)
@@ -381,7 +381,8 @@
if (editorFlags.isEditing == NO)
return YES;
- NSResponder *firstResponder = [[self window] firstResponder];
+ NSWindow *window = [self window];
+ NSResponder *firstResponder = [window firstResponder];
/*
Need to finalize text field cells being edited or the abstract/annote
text views, since the
@@ -402,7 +403,7 @@
}
// commit edits (formatters may refuse to allow this)
- if ([[self window] makeFirstResponder:[self window]] == NO)
+ if ([window makeFirstResponder:window] == NO)
return NO;
// for inherited fields, we should do something here to make sure the
user doesn't have to go through the warning sheet
@@ -410,7 +411,7 @@
if (editedRow != -1) {
// fields may be changed due to the commit
[self editTextFieldAtRow:editedRow forField:editedField
selection:selection];
- } else if ([[self window] makeFirstResponder:firstResponder]) {
+ } else if ([window makeFirstResponder:firstResponder]) {
if ([firstResponder isKindOfClass:[NSTextField class]])
textView = (NSTextView *)[(NSTextField *)firstResponder
currentEditor];
[textView setSafeSelectedRanges:selection];
@@ -425,7 +426,8 @@
if (editorFlags.isEditing == NO)
return YES;
- NSResponder *firstResponder = [[self window] firstResponder];
+ NSWindow *window = [self window];
+ NSResponder *firstResponder = [window firstResponder];
/*
Need to finalize text field cells being edited or the abstract/annote
text views, since the
@@ -473,7 +475,7 @@
NSArray *selection = [textView selectedRanges];
// commit edits (formatters and validation methods should allow this
at this point)
- if ([[self window] makeFirstResponder:[self window]] == NO) {
+ if ([window makeFirstResponder:window] == NO) {
// should not be reached, we should have found errors above
if (error)
*error = [NSError localErrorWithCode:kBDSKFailedToCommit
localizedDescription:NSLocalizedString(@"Failed to commit edits", @"Error
message")];
@@ -485,7 +487,7 @@
if (editedRow != -1) {
// fields may be changed due to the commit
[self editTextFieldAtRow:editedRow forField:editedField
selection:selection];
- } else if ([[self window] makeFirstResponder:firstResponder]) {
+ } else if ([window makeFirstResponder:firstResponder]) {
if (textField)
textView = (NSTextView *)[textField currentEditor];
[textView setSafeSelectedRanges:selection];
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Bibdesk-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bibdesk-commit
