Revision: 30108
          http://sourceforge.net/p/bibdesk/svn/30108
Author:   hofman
Date:     2026-03-04 17:08:08 +0000 (Wed, 04 Mar 2026)
Log Message:
-----------
return bool from insertion dataSource method

Modified Paths:
--------------
    trunk/bibdesk/BDSKEditor.m
    trunk/bibdesk/BibDocument_DataSource.m

Modified: trunk/bibdesk/BDSKEditor.m
===================================================================
--- trunk/bibdesk/BDSKEditor.m  2026-03-04 17:07:55 UTC (rev 30107)
+++ trunk/bibdesk/BDSKEditor.m  2026-03-04 17:08:08 UTC (rev 30108)
@@ -1646,7 +1646,7 @@
     return YES;
 }
 
-- (void)fileView:(FVFileView *)aFileView insertURLs:(NSArray *)absoluteURLs 
atIndexes:(NSIndexSet *)aSet forDrop:(id <NSDraggingInfo>)info 
dropOperation:(FVDropOperation)operation;
+- (BOOL)fileView:(FVFileView *)aFileView insertURLs:(NSArray *)absoluteURLs 
atIndexes:(NSIndexSet *)aSet forDrop:(id <NSDraggingInfo>)info 
dropOperation:(FVDropOperation)operation;
 {
     NSMutableArray *files = [NSMutableArray array];
     
@@ -1654,7 +1654,7 @@
         BDSKLinkedFile *aFile = [BDSKLinkedFile linkedFileWithURL:aURL 
delegate:publication];
         if (aFile == nil) {
             NSBeep();
-            return;
+            return NO;
         }
         [files addObject:aFile];
     }
@@ -1674,6 +1674,7 @@
     }
     
     [self updateStatusForAutoGenerate:mask];
+    return YES;
 }
 
 - (BOOL)fileView:(FVFileView *)fileView deleteURLsAtIndexes:(NSIndexSet 
*)indexSet;

Modified: trunk/bibdesk/BibDocument_DataSource.m
===================================================================
--- trunk/bibdesk/BibDocument_DataSource.m      2026-03-04 17:07:55 UTC (rev 
30107)
+++ trunk/bibdesk/BibDocument_DataSource.m      2026-03-04 17:08:08 UTC (rev 
30108)
@@ -1624,10 +1624,10 @@
     return YES;
 }
 
-- (void)fileView:(FVFileView *)aFileView insertURLs:(NSArray *)absoluteURLs 
atIndexes:(NSIndexSet *)aSet forDrop:(id <NSDraggingInfo>)info 
dropOperation:(FVDropOperation)operation {
+- (BOOL)fileView:(FVFileView *)aFileView insertURLs:(NSArray *)absoluteURLs 
atIndexes:(NSIndexSet *)aSet forDrop:(id <NSDraggingInfo>)info 
dropOperation:(FVDropOperation)operation {
     BibItem *publication = [self singleSelectedPublication];
     if (publication == nil)
-        return;
+        return NO;
     
     NSMutableArray *files = [NSMutableArray array];
     
@@ -1635,7 +1635,7 @@
         BDSKLinkedFile *aFile = [BDSKLinkedFile linkedFileWithURL:aURL 
delegate:publication];
         if (aFile == nil) {
             NSBeep();
-            return;
+            return NO;
         }
         [files addObject:aFile];
     }
@@ -1651,6 +1651,8 @@
                 [publication autoFileLinkedFile:aFile];
         }
     }
+    
+    return YES;
 }
 
 - (void)trashFiles:(NSArray *)fileURLs {

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.



_______________________________________________
Bibdesk-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bibdesk-commit

Reply via email to