On 27 Aug 2007, at 11:58 PM, Adam R. Maxwell wrote: > > On Monday, August 27, 2007, at 02:47PM, > <[EMAIL PROTECTED]> wrote: >> Revision: 11003 >> http://bibdesk.svn.sourceforge.net/bibdesk/? >> rev=11003&view=rev >> Author: hofman >> Date: 2007-08-27 14:47:35 -0700 (Mon, 27 Aug 2007) >> >> Log Message: >> ----------- >> Use float math functions for float arguments. > > Okay, so I'm curious: was there any point in this since the MIN > macro uses __typeof to handle the types? It seems to me that one > potential advantage of using the NSObjCRuntime.h macros is that > they might handle 64-bit types more correctly (google for "typedef > CGFloat"), but I haven't looked at it in detail. > > -- > adam
Not really. But e.g. minf is defined for double, while it is used on floats. So fminf is more correct. And it removes the extra check for the __typeof. Note that I only did it for cases where the arguments were explicitly floats (either declared as such or for components of rects etc which are declared as floats). As for 64 bits, wouldn't that just change sizeof(float) ? And I cannot imagine that sizes and points will have an advantage from 64 bits, as float has more than enough capacity for its use. Christiaan ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ Bibdesk-develop mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/bibdesk-develop
