On 29 Aug 2007, at 8:07 PM, Adam R. Maxwell wrote: > I just discovered why the contentStringType was passed in to > BibDocument's newPublicationsForString:type:error: method. Oops. > I'd rather not make that mistake again, but right now we have a > disconnect between BibTeXParser and the other parsers that makes > this difficult. If we could give them all the same method > signature, that would be more effective. > > Options I see: > > 1) get rid of the partial data flag, since people just ignore the > dire warning anyway
I think that's what we had t some point, and you changed it back ;-) > 2) add owner and partial data parameters to all the other parsers > 3) try to remember special cases for BibTeX and non-key BibTeX > 4) have the BDSKStringParser class handle the partial data crap, > since it doesn't need the document > 5) other? > > For some of these options, we'd have to set the owner after reading > the string, or pass a BDSKOwner to the parser methods. Oh, we'd > also need a new parser class for the no-key bibtex type, but it > would just be a subclass of BibTeXParser. Other ideas? > > -- > Adam The no-key bibtex type should be handled separately anyway, because it may lead to an alert. Moreover, it is only acceptable in certain cases, not always. For the rest, I'm not sure at the moment. There are a lot of subtleties. For instance, setting the owner enables undo. And then there's the error handling from btparse. But at the moment I think something like 2 might be best. Christiaan ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ Bibdesk-develop mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/bibdesk-develop
