On 2 Sep 2007, at 6:04 PM, Adam R. Maxwell wrote:
>
> On Sep 2, 2007, at 04:51, [EMAIL PROTECTED] wrote:
>
>> Revision: 11043
>> http://bibdesk.svn.sourceforge.net/bibdesk/?
>> rev=11043&view=rev
>> Author: hofman
>> Date: 2007-09-02 04:51:17 -0700 (Sun, 02 Sep 2007)
>>
>> Log Message:
>> -----------
>> Replace any line endings by LF.
>>
>> + unsigned const char *bytePtr = [fixedData mutableBytes];
>
> Does this give a warning? I didn't think you could use const with
> mutableBytes. The const qualifier confuses me, though...
>
I more or less copied the const from NSData-OAExtensions. I'm
actually a bit confused myself, would this mean that the unsigned
char is constant, or the pointer to it? I don't get a warning though.
>> + if (ch != '\n' && [[NSCharacterSet newlineCharacterSet]
>> characterIsMember:ch]) {
>
> Are all characters in +newlineCharacterSet guaranteed to be
> sizeof(char)? If so, I guess this will work, but in general I think
> it's tricky to use NSData raw bytes with NSCharacterSet.
>
According to the docs, this set consists of U+000A–U+000D, U+0085, so
they're all sizeof(char), I would say. Anyway, I don't think it
should matter, because what matters is the argument. If there was a
larger-size character in the set it just would never match.
Christiaan
> --
> Adam
>
> ----------------------------------------------------------------------
> ---
> This SF.net email is sponsored by: Splunk Inc.
> Still grepping through log files to find problems? Stop.
> Now Search log events and configuration files using AJAX and a
> browser.
> Download your FREE copy of Splunk now >> http://get.splunk.com/
> _______________________________________________
> Bibdesk-develop mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/bibdesk-develop
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Bibdesk-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bibdesk-develop
