Can we be sure this won't happen with CR? Christiaan
On 5 Sep 2007, at 4:42 PM, Adam R. Maxwell wrote: > In fact, this is what's happening. See > > https://sourceforge.net/tracker/index.php? > func=detail&aid=1788443&group_id=61487&atid=497423 > > where the user had the problem with UTF8 D1 85, where 85 would match > the 0085 unichar. That's what I was afraid of in mixing bytes with > NSCharacterSet. > > On Sep 5, 2007, at 07:33, Adam R. Maxwell wrote: > >> I think the problem is that it's getting a decomposed UTF-8 byte of a >> Japanese character that appears to be a member of the UTF-16 newline >> character set. If that's the case, casting the char to unichar won't >> work. Haven't tried yet, or looked at the raw bytes in the file. >> >> Line numbering in the error editor was also off by 10 lines or so, >> which is odd. >> >> >> On Sep 5, 2007, at 02:11, Christiaan Hofman wrote: >> >>> Would declaring and typing the ch to unichar work instead? >>> >>> unichar ch; >>> ... >>> ch = (unichar)bytePtr[currIndex]; >>> >>> Christiaan >>> >>> On 5 Sep 2007, at 8:52 AM, [EMAIL PROTECTED] wrote: >>> >>>> Revision: 11070 >>>> http://bibdesk.svn.sourceforge.net/bibdesk/? >>>> rev=11070&view=rev >>>> Author: amaxwell >>>> Date: 2007-09-04 23:52:02 -0700 (Tue, 04 Sep 2007) >>>> >>>> Log Message: >>>> ----------- >>>> Revert a previous commit: testing single byte characters for >>>> membership in NSCharacterSet does not work. >>>> >>>> Modified Paths: >>>> -------------- >>>> trunk/bibdesk/BDSKBibTeXParser.m >>>> >>>> Modified: trunk/bibdesk/BDSKBibTeXParser.m >>>> =================================================================== >>>> --- trunk/bibdesk/BDSKBibTeXParser.m 2007-09-05 05:06:44 UTC (rev >>>> 11069) >>>> +++ trunk/bibdesk/BDSKBibTeXParser.m 2007-09-05 06:52:02 UTC (rev >>>> 11070) >>>> @@ -163,12 +163,12 @@ >>>> >>>> ch = bytePtr[currIndex]; >>>> >>>> - if (ch != '\n' && [[NSCharacterSet newlineCharacterSet] >>>> characterIsMember:ch]) { >>>> + if (ch == '\r') { >>>> >>>> replaceRange.location = currIndex; >>>> // check the next char to see if we have a Windows >>>> line ending >>>> nextIndex = currIndex + 1; >>>> - if (inputDataLength > nextIndex && ch == '\r' && >>>> bytePtr[nextIndex] == '\n') >>>> + if (inputDataLength > nextIndex && bytePtr[nextIndex] >>>> == '\n') >>>> replaceRange.length = 2; >>>> else >>>> replaceRange.length = 1; >>>> >>>> >>>> This was sent by the SourceForge.net collaborative development >>>> platform, the world's largest Open Source development site. >>>> >>>> ------------------------------------------------------------------- >>>> --- >>>> --- >>>> This SF.net email is sponsored by: Splunk Inc. >>>> Still grepping through log files to find problems? Stop. >>>> Now Search log events and configuration files using AJAX and a >>>> browser. >>>> Download your FREE copy of Splunk now >> http://get.splunk.com/ >>>> _______________________________________________ >>>> Bibdesk-commit mailing list >>>> [EMAIL PROTECTED] >>>> https://lists.sourceforge.net/lists/listinfo/bibdesk-commit >>> >>> >>> -------------------------------------------------------------------- >>> ----- >>> This SF.net email is sponsored by: Splunk Inc. >>> Still grepping through log files to find problems? Stop. >>> Now Search log events and configuration files using AJAX and a >>> browser. >>> Download your FREE copy of Splunk now >> http://get.splunk.com/ >>> _______________________________________________ >>> Bibdesk-develop mailing list >>> [email protected] >>> https://lists.sourceforge.net/lists/listinfo/bibdesk-develop >> >> >> --------------------------------------------------------------------- >> ---- >> This SF.net email is sponsored by: Splunk Inc. >> Still grepping through log files to find problems? Stop. >> Now Search log events and configuration files using AJAX and a >> browser. >> Download your FREE copy of Splunk now >> http://get.splunk.com/ >> _______________________________________________ >> Bibdesk-develop mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/bibdesk-develop > > > ---------------------------------------------------------------------- > --- > This SF.net email is sponsored by: Splunk Inc. > Still grepping through log files to find problems? Stop. > Now Search log events and configuration files using AJAX and a > browser. > Download your FREE copy of Splunk now >> http://get.splunk.com/ > _______________________________________________ > Bibdesk-develop mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/bibdesk-develop ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ Bibdesk-develop mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/bibdesk-develop
