On Dec 8, 2007, at 10:17 AM, Christiaan Hofman wrote:

>
> On 8 Dec 2007, at 5:56 PM, Adam R. Maxwell wrote:
>
>>
>> On Dec 8, 2007, at 5:04 AM, Christiaan Hofman wrote:
>>
>>>
>>> On 8 Dec 2007, at 4:15 AM, Adam R. Maxwell wrote:
>>>
>>>>
>>>> On Dec 7, 2007, at 2:14 PM, Christiaan Hofman wrote:
>>>>
>>>>>
>>>>> I've put the test app in the bibdesk directory if you want to
>>>>> have a
>>>>> look at it. With the bezel style it seems to work, the normal  
>>>>> style
>>>>> and bordered style don't work properly.
>>>>
>>>> What doesn't work in the normal/bordered styles?  Editing seemed to
>>>> work ok for me.
>>>
>>> The field editor covers the arrow/file button (apart from about 1
>>> px). Also the focus ring is cut off in an ugly way.
>>
>> The editor problem is weird.  The focus ring is also cut off in the
>> top row of the form, which has always been annoying.
>>
>
> It seems NSTextField uses vastly different interpretations of the
> various rects it calculates for editing. It's something like:
>
> normal:
> width(field editor) = width(selectedRect)
> width(focusring) = width(selectedRect) + width(cellFrame) - width
> (drawingRect) - margin
>
> bezeled:
> width(field editor) = width(drawingRect)
> width(focusring) =  width(cellFrame)
>
> bordered:
> width(field editor) = width(selectedRect) - margin
> width(focusring) =  width(selectedRect) + width(cellFrame) - width
> (drawingRect)
>
> This is extremely confusing.


To say the least!  I've always thought the field editor position and  
text baseline seems too high for non-bezeled cells, too, and it must  
be hardcoded somewhere.

>
>
>>>> The bezel style looks most familiar.  A grid doesn't
>>>> look so bad either (better than the bordered style cells, I
>>>> think).  I
>>>> wonder if some sort of custom bezel would look good---maybe a  
>>>> round-
>>>> rect or something...
>>>>
>>>
>>> A round rect is associated to search fields.
>>
>> I wasn't thinking of the round bezel, but something similar to a
>> tableview grid with rounded corners.  Doesn't look that great,  
>> though.
>>
>
> Not too bad, but probably not too good. Is this something standard in
> Leopard?

Nope, just drawing a bezier path in the cell.

>> I'll check out your changes.  I made a few minor ones also (another
>> cell subclass so the label column doesn't draw white text when
>> highlighted).
>>
>> -- 
>> adam 
>> ------------------------------------------------------------------
>> -------
>
> When does that happen? Does it show the highlight color (it  
> shouldn't)?

When you select a row for editing, the selected label column draws  
white text, since it's highlighted.  This probably doesn't affect  
Tiger and earlier because of the kludge they use to determine if a  
cell is highlighted.  For Leopard, the fix is trivial:

@implementation BlackTextFieldCell

- (NSBackgroundStyle)backgroundStyle { return NSBackgroundStyleLight / 
* 0 */; }

@end




-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
Bibdesk-develop mailing list
Bibdesk-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bibdesk-develop

Reply via email to