Should we really leave the logs in for the release? Not finding any pubs really is not an error, the vast majority of pages in the web won't have items we can't recognize.
Christiaan On 14 Dec 2007, at 5:46 AM, [EMAIL PROTECTED] wrote: > Revision: 11906 > http://bibdesk.svn.sourceforge.net/bibdesk/? > rev=11906&view=rev > Author: amaxwell > Date: 2007-12-13 20:46:07 -0800 (Thu, 13 Dec 2007) > > Log Message: > ----------- > Remove #warning and log. Looks okay after checking the header. > > Modified Paths: > -------------- > trunk/bibdesk/BDSKWebGroupViewController.m > > Modified: trunk/bibdesk/BDSKWebGroupViewController.m > =================================================================== > --- trunk/bibdesk/BDSKWebGroupViewController.m 2007-12-14 04:45:54 > UTC (rev 11905) > +++ trunk/bibdesk/BDSKWebGroupViewController.m 2007-12-14 04:46:07 > UTC (rev 11906) > @@ -288,7 +288,6 @@ > newPubs = [document > newPublicationsForString:string type:type verbose:NO error:&error]; > } > if (nil == newPubs) { > -#warning remove for release > // !!! logs are here to help diagnose problems that > users are reporting > NSLog(@"-[%@ [EMAIL PROTECTED] %@", [self class], > NSStringFromSelector(_cmd), error); > NSLog(@"loaded MIME type %@", [[dataSource > mainResource] MIMEType]); > @@ -307,15 +306,11 @@ > } > > - (void)webView:(WebView *)sender didFailProvisionalLoadWithError: > (NSError *)error forFrame:(WebFrame *)frame{ > -#warning FIXME: is this really a failure? > - // arm: I'm not sure what the provisional load failure > implies; from the docs it sounds like things will continue loading, > so do we really want to kill things here? If anyone knows or has a > test case for this, please comment. > if (frame == loadingWebFrame) { > [self setRetrieving:NO]; > [group addPublications:nil]; > loadingWebFrame = nil; > } > - // !!! logs are here to help diagnose problems that users are > reporting > - NSLog(@"-[%@ [EMAIL PROTECTED] %@", [self class], NSStringFromSelector > (_cmd), error); > } > > - (void)webView:(WebView *)sender didFailLoadWithError:(NSError *) > error forFrame:(WebFrame *)frame{ > > > This was sent by the SourceForge.net collaborative development > platform, the world's largest Open Source development site. > > ---------------------------------------------------------------------- > --- > SF.Net email is sponsored by: > Check out the new SourceForge.net Marketplace. > It's the best place to buy or sell services > for just about anything Open Source. > http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/ > marketplace > _______________________________________________ > Bibdesk-commit mailing list > [EMAIL PROTECTED] > https://lists.sourceforge.net/lists/listinfo/bibdesk-commit ------------------------------------------------------------------------- SF.Net email is sponsored by: Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace _______________________________________________ Bibdesk-develop mailing list Bibdesk-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bibdesk-develop
