On 24 Dec 2007, at 6:37 PM, Adam R. Maxwell wrote: > > On Dec 24, 2007, at 3:34 AM, Christiaan Hofman wrote: > >> >> On 24 Dec 2007, at 3:29 AM, Adam R. Maxwell wrote: >> >>> >>> On Dec 23, 2007, at 11:44 AM, Christiaan Hofman wrote: >>> >>>> >>>> On 23 Dec 2007, at 8:04 PM, Adam R. Maxwell wrote: >>>> >>>>> Good grief...do we really need 6 ivars and 4 early returns to work >>>>> around a minor bug in a legacy OS? I switched from cells to >>>>> NSButtons >>>>> precisely because they can be added as subviews, so they take >>>>> care of >>>>> drawing and tracking. >>>>> >>>> >>>> It's only 3 ivars. I don't think it 's that much of a change. >>> >>> It's quite a bit of extra tracking and drawing in the view. Did you >>> try overriding the button's tooltip and tracking rect methods? >>> Presumably that's where the conflict occurs. >>> >> >> I doubt it, I think it's the (un)hiding of views. > > How would that affect it? > >> The early returns >> are removed now, and I've greatly reduced the tracking code by moving >> it to the buttoncell. In fact, with the button class removed I think >> we've even less lines of code. And some expensive views are now >> replaced with just the cells. > > Don't try a performance argument with me :). I spent enough time > profiling it to know that the buttons weren't a bottleneck! But > thanks for removing the early returns, and I apologize for my > unnecessarily grumpy response. > >>>>> In addition, drawing is now broken in the test project when icons >>>>> are >>>>> selected, so some thorough testing is in order (and I don't have >>>>> time >>>>> for it). >>>>> >>>> >>>> Not on Tiger. What is broken? >>> >>> In the sample project, draw a rubberband selection and icons draw in >>> completely wrong locations. >>> >> >> Don't see it. It's also strange, as there is no difference in drawing >> apart from the arrows. > > Maybe it's some other recent change, then. Looks like it only > happens with a ragged bottom row. As soon as the mouse is > released, the icons move around and draw in the wrong place. >
Perhaps it's a setNeedsDisplay: call. I changed it to setNeedsDisplayInRect: in mouseUp:. > > <Picture 2.jpg><Picture 1.jpg> >> And also the Leopard target is irrelevant. > > What Leopard target? The bundle is required for the Quick Look > icon subclass. > > -- > adam I mean: the Leopard target is the only difference between the Leopard and Tiger build of the App target (apart from the system it runs on of course). Christiaan ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Bibdesk-develop mailing list Bibdesk-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bibdesk-develop
