On Dec 27, 2007 3:55 PM, Christiaan Hofman <[EMAIL PROTECTED]> wrote:
>
> On 26 Dec 2007, at 9:11 PM, Adam R. Maxwell wrote:
>
> >
> > On Dec 26, 2007, at 11:23 AM, Christiaan Hofman wrote:
> >
> >> On Dec 26, 2007 8:07 PM, Adam R. Maxwell <[EMAIL PROTECTED]> wrote:
> >>
> >>> Though I don't
> >>> precisely know how the search objects work, I always get confused
> >>> when I look at those objects.
> >>
> >> Which objects in particular? I could comment them more thoroughly if
> >> that would help. Most of the code is just an Obj-C wrapper around
> >> the
> >> Search Kit functions, but it's complicated because we search the
> >> index
> >> while it's being created in another thread. Search Kit doesn't make
> >> that easy; I think the design is oriented towards searching after the
> >> index is fully created.
> >>
> >> Basically all objects. It's not clear to me what the role is of each
> >> object (apart perhaps the window controller). Aggrevated by the fact
> >> that there are two types of search indexes, with no way to
> >> distinguish where they belong from the name.
> >
> > Well, the index with "Item" in the name is for BibItems, and the other
> > one is for file contents; when BDSKSearchIndex was created, I didn't
> > think we'd be using indexes elsewhere.
> >
> > I'll start documenting those classes; there are some weak
> > relationships that are tricky, and the interaction with SKSearch's
> > async searching adds more complexity. How about if we contemplate
> > this feature for a bit longer and release a new version in the
> > meantime? That would help limit the scope of potential bugs.
> >
> > --
> > adam
>
> Unless it will take a while we could probably better wait. I
> committed some changes in this direction (added the identifierURL to
> the search index info, which is a better way to preserve the
> selection as well, and added an array for filtered items). But those
> are (mostly) unused now, but make it possible to test. Though I
> tested it by binding to filteredResults, and setting the fileterURLs
> when search content starts as well as when the selection changes, and
> it works pretty well. If we send the search: action to the correct
> target after updating the grouped pubs it even does not flash the table.
>
> Christiaan
Perhaps we could do it for this release. It works well, I haven't seen any
problems, and it requires only 2 changes.
Christiaan
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Bibdesk-develop mailing list
Bibdesk-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bibdesk-develop
