On 1 Jan 2008, at 6:07 PM, Adam R. Maxwell wrote: > > On Jan 1, 2008, at 8:40 AM, Christiaan Hofman wrote: > >> Wouldn't it be better to draw the shadow in the icon, rather than in >> drawRect? This would remove the needsShadow and draws the shadow >> inside the icon. > > That seems wrong to me, since the shadow is cast on the view. > Wouldn't it require changing the geometry of the icon drawing to > account for the shadow offset and blur? It's not clear what the blur > value represents in points, so I'm not sure how to pad it, and I think > the offset and blur would still have to be changed with scale, as > well.
Yes, it could be a fixed fraction of the icon size. Also if the same icon is drawn at a different scale the shadow scales automatically. See also Skim's thumbnails. The padding for the shadow can easily be calculated from the blurradius and the offset. > The Icon Services shadows are part of the icon bitmaps, > unfortunately, so can't be disabled (and it's definitely impossible to > match them). > > -- > adam That's a reason I propose it, so it would be consistent, and really only when the icon is created do you know if it needs a shadow. Christiaan ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Bibdesk-develop mailing list Bibdesk-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bibdesk-develop
