The stop button was meant as a way to stop the incremental tableview updates without clearing the search field and removing the search result view. A complication was that the indexing progress bar still needed to update, and that's driven by callbacks from the index.
I think we can probably remove the stop button without much loss. I haven't used it for a long time. On Monday, January 21, 2008, at 08:05AM, "Christiaan Hofman" <[EMAIL PROTECTED]> wrote: >So it doesn't work, unfortunately. Then we need to do something else, >or have different cancel methods. I'm confused about the cancel >method in BDSKFileSearch. I also think the Stop button is confusing. >Anyway, there should be a way to really stop the search. > >Christiaan > > >On 21 Jan 2008, at 4:48 PM, Adam R. Maxwell wrote: > >> Does this work? The search string needs to stay around since -cancel >> gets called in searchIndexDidUpdate: (which may be why I checked for >> search == NULL in searchIndexDidUpdate). >> On Jan 21, 2008, at 7:36 AM, [EMAIL PROTECTED] wrote: >> >>> Revision: 12610 >>> http://bibdesk.svn.sourceforge.net/bibdesk/? >>> rev=12610&view=rev >>> Author: hofman >>> Date: 2008-01-21 07:36:50 -0800 (Mon, 21 Jan 2008) >>> >>> Log Message: >>> ----------- >>> Clear the search string in the search on cancel, otherwise the index >>> delegate method will revive it. >>> >>> Modified Paths: >>> -------------- >>> trunk/bibdesk/BDSKFileSearch.m >>> >>> Modified: trunk/bibdesk/BDSKFileSearch.m >>> =================================================================== >>> --- trunk/bibdesk/BDSKFileSearch.m 2008-01-21 11:08:21 UTC (rev >>> 12609) >>> +++ trunk/bibdesk/BDSKFileSearch.m 2008-01-21 15:36:50 UTC (rev >>> 12610) >>> @@ -104,6 +104,7 @@ >>> >>> - (void)cancel; >>> { >>> + [self setSearchString:nil]; >>> [self setSearch:NULL]; >>> [searchResults removeAllObjects]; >>> } >>> >>> >>> This was sent by the SourceForge.net collaborative development >>> platform, the world's largest Open Source development site. >>> >>> --------------------------------------------------------------------- >>> ---- >>> This SF.net email is sponsored by: Microsoft >>> Defy all challenges. Microsoft(R) Visual Studio 2008. >>> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ >>> _______________________________________________ >>> Bibdesk-commit mailing list >>> [EMAIL PROTECTED] >>> https://lists.sourceforge.net/lists/listinfo/bibdesk-commit >> >> >> ---------------------------------------------------------------------- >> --- >> This SF.net email is sponsored by: Microsoft >> Defy all challenges. Microsoft(R) Visual Studio 2008. >> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ >> _______________________________________________ >> Bibdesk-develop mailing list >> Bibdesk-develop@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/bibdesk-develop > > >------------------------------------------------------------------------- >This SF.net email is sponsored by: Microsoft >Defy all challenges. Microsoft(R) Visual Studio 2008. >http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ >_______________________________________________ >Bibdesk-develop mailing list >Bibdesk-develop@lists.sourceforge.net >https://lists.sourceforge.net/lists/listinfo/bibdesk-develop > > ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Bibdesk-develop mailing list Bibdesk-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bibdesk-develop
