Hi Christiaan,
Thanks for the fixes/updates to the unit tests!
I noticed that svn 14023 breaks the RIS and PubMed parser unit tests. I
think that it is an assert too far. I guess OBASSERT only shows up in debug
Build Configuration. Commit follows.
Best,
Greg.
--
Author: hofman <hof...@0fceea05-a30d-0410-8a8b-80ef821fb0a1>
Date: Tue Jan 13 18:30:55 2009 +0000
add an assert to make sure the main API for the string parser is not
used on concrete subclasses
git-svn-id:
https://bibdesk.svn.sourceforge.net/svnroot/bibdesk/tr...@14023
0fceea05-a30d-0410-8a8b-80ef821fb0a1
diff --git a/bibdesk/BDSKStringParser.m b/bibdesk/BDSKStringParser.m
index b8a79e3..7dd50b1 100644
--- a/bibdesk/BDSKStringParser.m
+++ b/bibdesk/BDSKStringParser.m
@@ -96,12 +96,14 @@ static Class classForType(int stringType)
+ (BOOL)canParseString:(NSString *)string ofType:(int)stringType{
if (stringType == BDSKUnknownStringType)
stringType = [string contentStringType];
+ OBASSERT(self != [BDSKStringParser class]);
Class parserClass = classForType(stringType);
OBASSERT(parserClass != [BDSKStringParser class]);
return parserClass != Nil ? [parserClass canParseString:string] : NO;
}
+ (NSArray *)itemsFromString:(NSString *)string ofType:(int)stringType
error:(NSError **)outError{
+ OBASSERT(self != [BDSKStringParser class]);
if (stringType == BDSKUnknownStringType)
stringType = [string contentStringType];
OBASSERT(stringType != BDSKBibTeXStringType);
------------------------------------------------------------------------------
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
_______________________________________________
Bibdesk-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bibdesk-develop