Dear Christiaan and Adam, Thank you both for your comments on general design and code. For now, I will split the DOI parsing and external script into separate commits to trunk so that they can be inspected/reverted individually.
On 2009-01-13 23:54, "Maxwell, Adam R" <adam.maxw...@pnl.gov> wrote: >> A second feature allows an optional external script to be called before full >> text doi parsing that can rapidly check a PDF's attributes for a doi or >> check if the pdf name conforms to certain patterns typical of Elsevier or >> Nature Publishing Group journals. This speeds up addition of some PDFs. I >> guess this would make something hackable by knowledgeable end users. I have >> such a script that I have been using for a while. > > If there's a way to do this with a script hook, that would be preferable; > otherwise, I think a real plugin might be a better approach from a security > standpoint... Hmm, perhaps you could spell out the security concerns a bit more here, because I haven't thought about it too much. Is there a big difference between a script hook and providing a hidden preference for a shell script that is not set in the BD distribution? Ie it's up to the end user to download/write their own shell script at their own risk. Best, Greg. ------------------------------------------------------------------------------ This SF.net email is sponsored by: SourcForge Community SourceForge wants to tell your story. http://p.sf.net/sfu/sf-spreadtheword _______________________________________________ Bibdesk-develop mailing list Bibdesk-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bibdesk-develop