On 7 Feb 2009, at 11:50 PM, Adam R. Maxwell wrote: > > On Feb 7, 2009, at 2:20 PM, Christiaan Hofman wrote: > >> >> On 7 Feb 2009, at 9:51 PM, Adam R. Maxwell wrote: >> >>> >>> On Feb 7, 2009, at 11:42 AM, Christiaan Hofman wrote: >>> >>>> Could you do me a favor and check Skim for deprecated methods >>>> whenever >>>> you find time? Thanks. >>> >>> Very few warnings at all; nice work! I sent Andy patches for the >>> warnings in Sparkle, I think, when I started using it in TLU. >>> >> >> I'm a bit surprised by the sign warning, as I usually do get those. >> For example always in BD. > > Using the ABS macro should get rid of that one, I think. >
I found a better solution, because in fact I don't trust taking the difference of two unsigned values. The difference is also unsigned, so when the second value is bigger, you get a large positive value rather than a small negative value (I think). >>> Have you tried running clang on Skim or BD? I can build a new >>> version and post results from that as well... >>> >> >> I've actually never tried clang. > > Here's what current svn of clang gives: > > http://homepage.mac.com/amaxwell/.Public/BibDesk-scan-build-2009-02-07-1.zip > > http://homepage.mac.com/amaxwell/.Public/Skim-scan-build-2009-02-07-2.zip > > Beware of false positives... Thanks, I'll have a look at them later. Getting late. Christiaan ------------------------------------------------------------------------------ Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM) software. With Adobe AIR, Ajax developers can use existing skills and code to build responsive, highly engaging applications that combine the power of local resources and data with the reach of the web. Download the Adobe AIR SDK and Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com _______________________________________________ Bibdesk-develop mailing list Bibdesk-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bibdesk-develop
