[Bibdesk-develop] OF BDSKSimpleLock.h and copyrights

Sat, 21 Feb 2009 22:32:09 -0800

Nightly build failed tonight, according to the e-mail from my build program:
In file included from /Volumes/Local/Users/amaxwell/build/bibdesk- clean/BDSKTeXTask.h:41, from /Volumes/Local/Users/amaxwell/build/bibdesk- clean/BibDocument_DataSource.m:52: /Volumes/Local/Users/amaxwell/build/bibdesk-clean/BDSKSimpleLock.h: 108:25: error: missing ')' in expression 


Fixing this is pretty easy, although it would be better just to  
replace all usage of OFSimpleLock with NSLock, or OSSpinLock if a  
spinlock is really desirable (which it generally isn't).



Checking this brought up another issue, though.  I'm quite skeptical  
of the legitimacy of copying a bunch of Omni's code and changing the  
license terms and copyright holder.  Even if the MIT license permits  
that, which isn't clear to me, it seems kind of shady...but I make no  
pretense of being a lawyer.



Also, it looks like a find-and-replace (probably of "OF") jacked up  
the licence terms in all the source files, too, based on the  
occurrences of "BDSK" here:


 THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
 "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT

 LIMITED TO, THE IMPLIED WARRANTIES BDSK MERCHANTABILITY AND FITNESS  
FOR

 A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
 OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
 SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT

 LIMITED TO, PROCUREMENT BDSK SUBSTITUTE GOODS OR SERVICES; LOSS BDSK  
USE,

 DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 THEORY BDSK LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT

 (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT BDSK THE  
USE
 BDSK THIS SOFTWARE, EVEN IF ADVISED BDSK THE POSSIBILITY BDSK SUCH  
DAMAGE.





Attachment:
smime.p7s

Description: S/MIME cryptographic signature


------------------------------------------------------------------------------
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
_______________________________________________
Bibdesk-develop mailing list
Bibdesk-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bibdesk-develop






















					Reply via email to