On Aug 26, 2009, at 5:08, Adam R. Maxwell wrote:

>
> On Aug 25, 2009, at 1:13 PM, Christiaan Hofman wrote:
>
>>
>> On Aug 25, 2009, at 19:33, Maxwell, Adam R wrote:
>>
>>> If you haven't tried running under valgrind yet, I'd give that a
>>> shot.  It's
>>> pretty good for finding memory smashers, and is easy to compile and
>>> install.
>
> Running it under valgrind froze my system, which was interesting.  I  
> didn't have time to try again.
>
>>> I'd be happy run it through the clang static analyzer and post
>>> results from
>>> that again.
>>>
>>
>> This doesn't really look like a memory smasher, I think nil is used
>> for an argument where it's not accepted.
>
> Maybe; I won't claim to be an expert on interpreting crash reports.   
> A NULL-dereference bug in libobjc code under  
> _class_lookupMethodAndLoadCache is unlikely, though...
>
>> Anyway, even with tools it is
>> hard to find it when we don't know which (contextual) menu caused the
>> crash.
>
> If it's a menu.  Years ago we had an extra autorelease in  
> BDSKConverter that showed up as a weird exception in a formatter,  
> but only under very specific conditions.  A user finally was able to  
> reproduce it reliably enough for Mike to fix it.

Sure, but the precise menu is the first step in unravelling the thread.

>
> Anyway, I noted a few bugs reported by clang and fixed a couple of  
> the simpler ones; most of them look like simple fixes, but I'm not  
> up on all the code anymore.

Thanks, I fixed those as well.

> The double autorelease in the document save stuff is definitely  
> likely to cause random crashes, though.

Actually, that one is pretty safe, because the delegate is always nil,  
so that code path is never reached. The callback seems to be there  
only for subclasses.

Christiaan


------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Bibdesk-develop mailing list
Bibdesk-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bibdesk-develop

Reply via email to