On Jan 24, 2010, at 2:28 PM, Christiaan Hofman wrote:

> 
> On Jan 24, 2010, at 23:12, Adam R. Maxwell wrote:
> 
>> Regardless, it's a bug that's been blocking nightly builds...  
> 
> Makes my case that it should not block the nightly builds, it should only 
> warn.

Or perhaps it makes a case that you should run the unit tests yourself after 
rewriting things ;).

> 
>> How does the enum type test fail?  At compilation time or run time?
>> 
> 
> Running the unit tests, which happens at compile time. The SKAssertEquals 
> macro first compares the types of the values. I guess an enum value will 
> always be seen as a long, even though the type may be typedef'ed to 
> NSUInteger. Even though the compiler does not give a sign warning.

Oh, I see...it uses strcmp on @encode, so the check happens at run time.  For 
an enum, my recollection is that the compiler is free to use whatever size it 
wants, which is a problem with Apple's current style of declaring enum types.  
I guess you either have to cast or use STAssertTrue.  Anyway, those haven't 
been blocking nightly builds unless that's a recent change, so evidently only 
compile errors will actually prevent the upload.



------------------------------------------------------------------------------
Throughout its 18-year history, RSA Conference consistently attracts the
world's best and brightest in the field, creating opportunities for Conference
attendees to learn about information security's most important issues through
interactions with peers, luminaries and emerging and established companies.
http://p.sf.net/sfu/rsaconf-dev2dev
_______________________________________________
Bibdesk-develop mailing list
Bibdesk-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bibdesk-develop

Reply via email to