On Mar 30, 2014, at 22:41, Adam R. Maxwell wrote:

> 
> On Mar 30, 2014, at 13:38 , Reto Stöckli <[email protected]> wrote:
> 
>> The documentation does not mention any limitations on maximum allowed open 
>> sessions. Sessions timeout by themselves anyway. They just tell you that 
>> once a session is closed, not retrieved data from previous sessions (e.g. 
>> marked lists, not important for BibDesk) are lost.
> 
> In that case, I'd just add a comment to that effect in the code and forget 
> about it.
> 
> adam


Probably it still makes sense to close the session when the search group server 
is cleaned up in serverDidFinish. Probably should then be placed in a @try 
block.

Another thing, looking at the code it seems to me that the search is really 
done twice now, as the first search also gets all the records and not just the 
number of results. I think trying to read the documentation (which is really 
not clear on this point) the count in the first try should be 0 to get the 
total number, rather than 100 (or 1 in the old version). It does seem to work 
for me, and even gets me more results. (Oh, and use numberWithInteger: rather 
than the old numberWithInt:). 

Christiaan

------------------------------------------------------------------------------
_______________________________________________
Bibdesk-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bibdesk-develop

Reply via email to