> On 14 Dec 2017, at 18:30, Maxwell, Adam R <[email protected]> wrote:
>
> The problem is that it doesn’t get testing prior to release, in that case,
> and working with SPI is really tricky; I’ve done enough profiling to know
> that it didn’t leak when I wrote it, but who knows what they’ve changed since
> then. Maybe I can find time to update the OS on the build machine, but I’m
> not sure what version I can put on that hardware.
>
> From: Christiaan Hofman [mailto:[email protected]
> <mailto:[email protected]>]
> Sent: Thursday, December 14, 2017 9:20 AM
> To: About BibDesk development. <[email protected]
> <mailto:[email protected]>>
> Subject: Re: [Bibdesk-develop] nightly build problem
>
> I've now put the code for 10.13 between an sdk check so it won't be a problem
> when building on older systems. I am not completely sure about how bad the
> deprecated function is. I did not check for the leak, and the warning is not
> really clear about whether it leaks or not. It only says it may leak. But
> adding an extra release leads to an overrelease, so there does not seem to be
> an overretain. So I think as long as the actual release us built on High
> Sierra there should now be no problem.
>
> Christiaan
Annoyingly I am unable to profile Bibdesk with Leaks, because it just hangs
there when I try.
However, if I just profile some code block using CGDataProviderGetButePtr, I do
get a leak of the data provider.
So I have disabled the code path using this function on 10.13.
Christiaan
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Bibdesk-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bibdesk-develop
