[
https://issues.apache.org/jira/browse/BIGTOP-76?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13097684#comment-13097684
]
Bruno Mahé commented on BIGTOP-76:
----------------------------------
0/ Could you kill:
+ // repo = new PackageTestRepoMgr("3", "",
"http://nightly.cloudera.com/debian/";,
+ //
"http://nightly.cloudera.com/debian/archive.key";);
1/ This one should be in the utils (not necessary for this task if another
ticket is opened):
+ String arch = (new Shell()).exec("uname
-m").getOut().get(0).replaceAll(/i.86/,"i386").replaceAll(/x86_64/,"amd64");
+ String archTranslated = (type == "apt") ? "" : ((arch == "amd64") ?
".x86_64" : ".${arch}");
2/ I don't see golden (or pkgGolden) being used in TestPackagesBasics.
3/ Could we use constants for run levels?
4/ Could 3 be a constant? Maybe even use something like your tryOrFail static
method
for (i=3; pkg.install() && i>0; i--) {};
5/ This list should definitely be a constant somewhere:
+ } else if (["apt", "yum", "zypper"].contains(key)) { // poor man's XML
filtering
> Package tests need to be refactored in order to provide accurate reporting
> --------------------------------------------------------------------------
>
> Key: BIGTOP-76
> URL: https://issues.apache.org/jira/browse/BIGTOP-76
> Project: Bigtop
> Issue Type: Bug
> Reporter: Roman Shaposhnik
> Assignee: Roman Shaposhnik
> Attachments: BIGTOP-76.patch.txt
>
>
> We need to refactor the inheritance of Package smoke test to get rid of
> method stubbing and thus stop reporting empty tests as "passed"
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
