Misc improvments
-----------------
Key: BIGTOP-78
URL: https://issues.apache.org/jira/browse/BIGTOP-78
Project: Bigtop
Issue Type: Improvement
Components: Tests
Affects Versions: 0.1.0, 0.2.0
Reporter: Bruno Mahé
>From BIGTOP-76 in
>bigtop-tests/test-artifacts/package/src/main/groovy/org/apache/bigtop/itest/packagesmoke/TestPackagesBasics.groovy:
0/ Could you kill:
+ // repo = new PackageTestRepoMgr("3", "",
"http://nightly.cloudera.com/debian/";,
+ //
"http://nightly.cloudera.com/debian/archive.key";);
1/ This one should be in the utils (not necessary for this task if another
ticket is opened):
+ String arch = (new Shell()).exec("uname
-m").getOut().get(0).replaceAll(/i.86/,"i386").replaceAll(/x86_64/,"amd64");
+ String archTranslated = (type == "apt") ? "" : ((arch == "amd64") ?
".x86_64" : ".${arch}");
2/ I don't see golden (or pkgGolden) being used in TestPackagesBasics.
3/ Could we use constants for run levels?
4/ Could 3 be a constant? Maybe even use something like your tryOrFail static
method
for (i=3; pkg.install() && i>0; i--) {};
5/ This list should definitely be a constant somewhere:
+ } else if (["apt", "yum", "zypper"].contains(key)) { // poor man's XML
filtering
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
