[
https://issues.apache.org/jira/browse/BIGTOP-481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236319#comment-13236319
]
Roman Shaposhnik commented on BIGTOP-481:
-----------------------------------------
Thank a lot for the patch. A couple of things to note:
# please fix your indentation to follow whatever style we have (I believe its
no TABS and two spaces for each level of indentation)
# the method signature has 3 arguments, but the implementation has 4. not
sure what's happening there
# for the key==null it'll be easier to call an existing addBinRepo
Looking forward to your new patch!
> fix the way to handle repo key for Debian like system
> -----------------------------------------------------
>
> Key: BIGTOP-481
> URL: https://issues.apache.org/jira/browse/BIGTOP-481
> Project: Bigtop
> Issue Type: Bug
> Components: Debian
> Affects Versions: 0.3.0
> Reporter: Johnny Zhang
> Fix For: 0.3.0
>
> Attachments: BIGTOP-481.txt
>
>
> current bigtop package test for lucid doesn't import the key, hence the
> package installed is not authenticated.
> http://bigtop01.cloudera.org:8080/view/Bigtop-hadoop-0.23/job/Bigtop-hadoop-0.23-packagetest/label=lucid-slave/23/consoleFull
> search message "WARNING: The following packages cannot be authenticated!"
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
