[
https://issues.apache.org/jira/browse/BIGTOP-614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13295844#comment-13295844
]
Roman Shaposhnik commented on BIGTOP-614:
-----------------------------------------
Sujay, I agree with your comments above. Also, please include the following
clean up into your new patch:
# there doesn't seem to be any need for a shell class in TestHAFailover and
TestKillNNFailover
# the test shouldn't assume that it is executed under any specific user
account (e.g. assumptions that it is root). If something requires root
privileges it needs to be executed via a root shell. Something like shRoot =
new Shell("/bin/bash -s", "root")
# please get rid of System.out.println calls around shell calls. all shell
tracing is done via log4j
# it would be nice to get rid of the assertNotNull("JAVA_HOME has to be set
to run this test", JAVA_HOME) and assertNotNull("HADOOP_HOME has to be set to
run this test", HADOOP_HOME) in the HATestUtil
> Add HDFS HA tests
> -----------------
>
> Key: BIGTOP-614
> URL: https://issues.apache.org/jira/browse/BIGTOP-614
> Project: Bigtop
> Issue Type: Test
> Components: Tests
> Reporter: Stephen Chu
> Assignee: Stephen Chu
> Attachments: HATests.patch
>
>
> In this patch, I am adding 2 tests and a test util class.
> 1) TestHAFailover: Fails over between the NameNodes a configurable number of
> times. Checks the service state of each NN after each failover to ensure that
> the service state is correct.
> 2) TestKilLNNFailover: Kills the Active NN. Waits and fails over to the
> standby NN. Waits and checks that the former standby is now active. Restarts
> the killed NN and checks that it is now standby. Goes through this process a
> configurable number of times.
> 3) HATestUtil: Helper methods to fail over and kill the NameNodes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
