[ 
https://issues.apache.org/jira/browse/BIGTOP-678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13418971#comment-13418971
 ] 

Wing Yew Poon commented on BIGTOP-678:
--------------------------------------

Bruno, on second thoughts, I think I'd leave it the way it is for now. Using 
Integer.getInteger(String, int) would indeed be easier. However, using 
System.getProperty(String) makes it easier later to find all the properties 
used by the tests. Right now, we don't have a way in the tests to specify a 
contract, in particular, what are the inputs (possibly optional) to a test, 
which typically is done by setting system properties. Until we have some kind 
of annotation or other way (even just a convention) for specifying such a 
contract, I'd leave the property in a System.getProperty(String) call.
                
> make hive TestJdbcDriver more robust
> ------------------------------------
>
>                 Key: BIGTOP-678
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-678
>             Project: Bigtop
>          Issue Type: Improvement
>          Components: Tests
>    Affects Versions: 0.3.0, 0.4.0
>            Reporter: Wing Yew Poon
>            Assignee: Wing Yew Poon
>             Fix For: 0.5.0
>
>         Attachments: BIGTOP-678.txt
>
>
> I plan to attach a patch to make TestJdbcDriver more robust, by 
> parameterizing the wait time for the hive server to be up (it is currently 
> hardcoded to 1 second, which may not be long enough) and by introducing a 
> timeout to the test method (in my experience, if for some reason hive is not 
> up or otherwise able to respond successfully, the test hangs).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to