Confirm patch works, in both formats. Thanks !
On Thu, May 1, 2014 at 8:19 AM, Ali Jawad <alijaw...@gmail.com> wrote: > Hi Evan > You guys are doing a great job. I did actually try before without acl > directly in view. The error was at the time No ACL geoip. Will retry with > patch. Thanks ! > On May 1, 2014 6:38 AM, "Evan Hunt" <e...@isc.org> wrote: > >> On Wed, Apr 30, 2014 at 11:33:06PM +0200, Ali Jawad wrote: >> > Any hints ? >> >> So, yeah, that's embarrassing. It never crossed my mind to test geoip >> ACL elements by referencing them indirectly in named ACLs, as you did; >> I only referenced them directly. Apparently none of the folks who've >> been using the code in production ever tried that either. Kudos for >> your QA skills. :) >> >> Thanks to you, I am now aware of the fact that, while the following >> configuration does work: >> >> match-clients { geoip country US; }; >> >> ...this one doesn't: >> >> acl geoipUS { geoip country US; } >> ... >> match-clients { geoipUS; }; >> >> The problem is that when the "geoipUS" ACL is merged into match-clients >> for the view, the geoip information doesn't get copied correctly. >> >> The attached patch should fix it. >> >> -- >> Evan Hunt -- e...@isc.org >> Internet Systems Consortium, Inc. >> >
_______________________________________________ Please visit https://lists.isc.org/mailman/listinfo/bind-users to unsubscribe from this list bind-users mailing list bind-users@lists.isc.org https://lists.isc.org/mailman/listinfo/bind-users