On Sat, Oct 29, 2011 at 02:24:27AM +0400, Alexander V. Chernikov wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Hello list! > > Patch permits templates generation via 'template' keyword. Protocols can > inherit templates (and templates can inherit templates) via 'inherit' > keyword. At the moment patch supports BGP only (however adding other > protocols is trivial)
Great. Just one major comment - 'inherit' keyword inside a body of
protocol is (IMHO) not a good idea - it looks like option but it
is really something different (meta-option) and also silently
overwrites every option used before that (if not used first
in the body).
protocol bgp rr_cl_ft by rr_client_bb {
neighbor 10.4.7.2 as 65000;
}
(Not being native english speaker i am not sure whether 'by'
is really the most apt keyword, any comments on that? Perhaps
'from'?)
I will update the patch and merge it soon.
--
Elen sila lumenn' omentielvo
Ondrej 'SanTiago' Zajicek (email: [email protected])
OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net)
"To err is human -- to blame it on a computer is even more so."
signature.asc
Description: Digital signature
