On Fri, Jul 13, 2018 at 10:16:16PM +0200, Toke Høiland-Jørgensen wrote: > Since we have several places where we loop over a TLV stream, define a > helper macro to deal with framing checks and looping.
OK, but it also makes framing errors silent. I think there should be error message (like there is in the old code). And perhaps it could be called WALK_TLVS, like other iteration macros in BIRD. -- Elen sila lumenn' omentielvo Ondrej 'Santiago' Zajicek (email: santi...@crfreenet.org) OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net) "To err is human -- to blame it on a computer is even more so."
