Re: Static routes after `configure` CLI command

[Ondrej Zajicek]

On Mon, Dec 03, 2018 at 06:10:43PM +0500, Vladimir Osmolovskiy wrote:
>  On the master branch. Config file don't change.
> 
> protocol static {
> route 20.1.100.0 /24 multipath
>  via 10.10.10.2 weight 10;
> }

Hi

Seems that the issue is specific to static ECMP routes, which we forgot
to clean up, attached patch should fix it. Does it help?

-- 
Elen sila lumenn' omentielvo

Ondrej 'Santiago' Zajicek (email: santi...@crfreenet.org)
OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net)
"To err is human -- to blame it on a computer is even more so."

diff --git a/proto/static/static.c b/proto/static/static.c
index 849067b9..6ddff146 100644
--- a/proto/static/static.c
+++ b/proto/static/static.c
@@ -518,6 +518,11 @@ static_match(struct proto *p, struct static_route *r, struct static_config *n)
   if (r->neigh)
     r->neigh->data = NULL;
 
+  if (r->dest == RTD_MULTIPATH)
+    for (t = r->mp_next; t; t = t->mp_next)
+      if (t->neigh)
+	t->neigh->data = NULL;
+
   WALK_LIST(t, n->iface_routes)
     if (static_same_net(r, t))
       goto found;