On Wed, Nov 09, 2022 at 06:05:27PM +0100, Ondrej Zajicek via Bird-users wrote: > On Wed, Nov 09, 2022 at 05:34:07PM +0100, Ondrej Zajicek via Bird-users wrote: > > The whole issue is a bit silly, as it is a result of too many knobs that > > sometimes does not make sense. Setting keepalive independently of hold > > time, when hold time is negotiated (so consistency cannot be validated in > > config-parse time), is just bad design. It would be better if keepalive > > could be defines as a fraction of negotiated hold time. > > Thinking about it, perhaps a better approach would be to just scale the > keepalive timer based on (negotiated hold time / configured hold time).
Hi Scaling implemented, with both 'min hold time' and 'min keepalive time' option: https://gitlab.nic.cz/labs/bird/-/commit/3859e4efc1597368df647323c5a3cc1771cb64ca -- Elen sila lumenn' omentielvo Ondrej 'Santiago' Zajicek (email: [email protected]) OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net) "To err is human -- to blame it on a computer is even more so."
