On Wed, Dec 06, 2006 at 09:21:31PM -0500, Joel E. Denny wrote:
> On Wed, 6 Dec 2006, Bob Rossi wrote:
> 
> > Before I submit a patch, I make sure the test suite works. Then I do a
> > 'cp data/push.c data/yacc.c' and do a make install and make check.
> 
> It's also good to do a make maintainer-check before submitting your patch. 
> Search HACKING to learn about that and configure --enable-gcc-warnings.
> 
> Without copying push.c to yacc.c, make maintainer-check fails for tests 93 
> and 99.  Valgrind is detecting some errors.  Do you have Valgrind?
> 
> I've installed your patch, but we need to fix this.

Great! Yes, I have valgrind installed and I am very familiar with it.
The next thing I'll do is attept to fix those errors. Then we'll move on
to something more interesting.

Thanks for you help!
Bob Rossi


Reply via email to