On Sat, Dec 16, 2006 at 08:43:20PM -0500, Joel E. Denny wrote: > On Sat, 16 Dec 2006, Paul Eggert wrote: > > > "Joel E. Denny" <[EMAIL PROTECTED]> writes: > > > > > + m4_ifset([b4_parse_param], [,]) b4_parse_param)[ > > > > The patch overall looks fine to me, but one minor thing. In usages > > like this, it's better to put the empty item inside the conditional. > > That is: > > > > m4_ifset([b4_parse_param], [, b4_parse_param]))[ > > > > This is the usual style in Bison and it's easier to follow. > > I like that better. Thanks. Here's the updated patch, which I committed.
Thanks Joel. Do you have an open list of items you'd like me to fix? Thanks, Bob Rossi
