On Mon, 18 Dec 2006, Joel E. Denny wrote: > On Mon, 18 Dec 2006, Joel E. Denny wrote: > > > > Thanks for looking into it. My, there is a lot of clever code here > > > without much explanation.... But I'll give some quick feedback anyway. > > > > I should document the push.c changes better. I got too lazy at the end of > > that coding session. Maybe later today. > > By the way, thanks for the feedback regardless of my laziness. > > > > + YYCOPY (&yyptr->Stack##_alloc, Stack, yysize); \ > > > + Stack = &yyptr->Stack##_alloc; \ > > > > > > The current yacc.c doesn't use ##, since ## is not portable to K&R C. > > > > Thanks, I think I can work around that. > > Below is a small uncommitted patch against CVS Bison. It implements a > different solution to the above in preparation for my larger patch posted > earlier. Ok to commit?
We can adjust this small change later if it proves problematic, so I went ahead and committed it. I'll soon post a patch that takes another step in implementing my larger patch. It will depend on the small patch I just committed. By taking these smaller steps, I plan to document all parts of that larger patch that I didn't document before.
