I pushed this to branch-2.5 and master. Alex, would you please build Bison with "./configure --enable-gcc-warnings" and fix the remaining errors? You're missing void on a couple of function prototypes, and you're disobeying -Wshadow in many places. The latter, at least, is part of the GNU coding standards. Thanks.
>From a1ed2b71faac0de1db1c0e279ee3203115ec70d8 Mon Sep 17 00:00:00 2001 From: Joel E. Denny <[email protected]> Date: Wed, 29 Jul 2009 13:47:02 -0400 Subject: [PATCH] Fix a --enable-gcc-warnings problem. * src/scan-gram.l (SC_ESCAPED_CHARACTER): Actually use length variable. diff --git a/src/scan-gram.l b/src/scan-gram.l index 0c12cba..422eae6 100644 --- a/src/scan-gram.l +++ b/src/scan-gram.l @@ -472,9 +472,9 @@ splice (\\[ \f\t\v]*\n)* { /* FIXME: Eventually, make these errors. */ size_t length = strlen (last_string); - if (strlen (last_string) < 3) + if (length < 3) warn_at (*loc, _("empty character literal")); - else if (strlen (last_string) > 3) + else if (length > 3) warn_at (*loc, _("extra characters in character literal")); } if (yytext[0] == '\n') -- 1.5.4.3
